Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1973023002: Revert of Don't include contents visual overflow into paint invalidation rect (Closed)

Created:
4 years, 7 months ago by Zhenyao Mo
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't include contents visual overflow into paint invalidation rect (patchset #5 id:80001 of https://codereview.chromium.org/1929413002/ ) Reason for revert: caused rendering regression, see crbug.com/611272 Original issue's description: > Don't include contents visual overflow into paint invalidation rect > > Now we always invalidate any object needing repaint, so we never need > the paint invalidation rect of an ancestor to cover descendants. > > BUG=436198 > > Committed: https://crrev.com/638c1a24dc8fdcceb5b5f4acd9d03d3a09b9cfa3 > Cr-Commit-Position: refs/heads/master@{#392652} TBR=chrishtr@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=436198

Patch Set 1 #

Messages

Total messages: 8 (1 generated)
Zhenyao Mo
Created Revert of Don't include contents visual overflow into paint invalidation rect
4 years, 7 months ago (2016-05-12 17:15:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1973023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1973023002/1
4 years, 7 months ago (2016-05-12 17:15:57 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/4568) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-12 17:18:56 UTC) #4
Xianzhu
On 2016/05/12 17:15:57, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-12 17:18:58 UTC) #5
Zhenyao Mo
A regression like that can sneak into chromium and stay for a week is really ...
4 years, 7 months ago (2016-05-12 17:25:41 UTC) #6
Zhenyao Mo
On 2016/05/12 17:25:41, Zhenyao Mo wrote: > A regression like that can sneak into chromium ...
4 years, 7 months ago (2016-05-12 17:27:02 UTC) #7
Xianzhu
4 years, 7 months ago (2016-05-12 17:29:27 UTC) #8
On 2016/05/12 17:25:41, Zhenyao Mo wrote:
> A regression like that can sneak into chromium and stay for a week is really
> concerning.  Good to know it's been fixed, can you point me to the fix?  We
> should find a way to test to prevent future regression.

https://bugs.chromium.org/p/chromium/issues/detail?id=611046#c3

Powered by Google App Engine
This is Rietveld 408576698