content/renderer/v8_value_converter_impl.h - Issue 19730002: V8ValueConverter for the activity logger that does not invoke interceptors and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/v8_value_converter_impl.h

Issue 19730002: V8ValueConverter for the activity logger that does not invoke interceptors and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ben's comments, fix for mac compilation Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/activity_log_converter_strategy.cc ('K') | « content/public/renderer/v8_value_converter.h ('k') | content/renderer/v8_value_converter_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/v8_value_converter_impl.h

diff --git a/content/renderer/v8_value_converter_impl.h b/content/renderer/v8_value_converter_impl.h

index f5ad10a4b81476d240ff5f74561c460fdb755fb6..20331648fab6e41c6e64c1e0235928e8dd1057a3 100644

--- a/content/renderer/v8_value_converter_impl.h

+++ b/content/renderer/v8_value_converter_impl.h

@@ -30,6 +30,7 @@ class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {

virtual void SetRegExpAllowed(bool val) OVERRIDE;

virtual void SetFunctionAllowed(bool val) OVERRIDE;

virtual void SetStripNullFromObjects(bool val) OVERRIDE;

+ virtual void SetStrategy(Strategy* strategy) OVERRIDE;

virtual v8::Handle<v8::Value> ToV8Value(

const base::Value* value,

v8::Handle<v8::Context> context) const OVERRIDE;

@@ -76,6 +77,9 @@ class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {

bool avoid_identity_hash_for_testing_;

+ // Strategy object that changes the converter's behavior.

+ Strategy* strategy_;

DISALLOW_COPY_AND_ASSIGN(V8ValueConverterImpl);

};