chrome/renderer/extensions/api_activity_logger.cc - Issue 19730002: V8ValueConverter for the activity logger that does not invoke interceptors and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/api_activity_logger.cc

Issue 19730002: V8ValueConverter for the activity logger that does not invoke interceptors and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ben's comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/extensions/activity_log_converter_strategy_unittest.cc ('K') | « chrome/renderer/extensions/activity_log_converter_strategy_unittest.cc ('k') | chrome/renderer/extensions/dom_activity_logger.cc » ('j') | content/renderer/v8_value_converter_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/api_activity_logger.cc

diff --git a/chrome/renderer/extensions/api_activity_logger.cc b/chrome/renderer/extensions/api_activity_logger.cc

index 28a4367ff15f71d4732f49d8f6997e162e8ca8b3..a6b95af98c90eda87d4519ae2d26f58cf43fb797 100644

--- a/chrome/renderer/extensions/api_activity_logger.cc

+++ b/chrome/renderer/extensions/api_activity_logger.cc

@@ -6,6 +6,7 @@

#include "base/bind.h"

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/renderer/chrome_render_process_observer.h"

+#include "chrome/renderer/extensions/activity_log_converter_strategy.h"

#include "chrome/renderer/extensions/api_activity_logger.h"

#include "content/public/renderer/render_thread.h"

#include "content/public/renderer/v8_value_converter.h"

@@ -56,6 +57,9 @@ void APIActivityLogger::LogInternal(

v8::Local<v8::Array> arg_array = v8::Local<v8::Array>::Cast(args[2]);

if (arg_array->Length() > 0) {

scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());

+ ActivityLogConverterStrategy strategy;

+ converter->SetFunctionAllowed(true);

+ converter->SetStrategy(&strategy);

scoped_ptr<ListValue> arg_list(new ListValue());

for (size_t i = 0; i < arg_array->Length(); ++i) {

arg_list->Set(i,