Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/renderer/extensions/activity_log_value_converter.h

Issue 19730002: V8ValueConverter for the activity logger that does not invoke interceptors and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: a nit Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_RENDERER_EXTENSIONS_ACTIVITY_LOG_VALUE_CONVERTER_H_
6 #define CHROME_RENDERER_EXTENSIONS_ACTIVITY_LOG_VALUE_CONVERTER_H_
7
8 #include "base/memory/scoped_ptr.h"
9 #include "content/public/renderer/v8_value_converter.h"
10 #include "v8/include/v8.h"
11
12 namespace base {
13 class Value;
14 }
15
16 namespace extensions {
17
18 class ActivityLogValueConverter {
felt 2013/07/18 17:28:20 Can you add a comment to explain why this new clas
pmarch 2013/07/18 20:42:03 Done.
19 public:
20 ActivityLogValueConverter();
21 virtual ~ActivityLogValueConverter();
22
23 base::Value* FromV8Value(v8::Handle<v8::Value> value,
24 v8::Handle<v8::Context> context) const;
25 private:
26 scoped_ptr<content::V8ValueConverter> v8_value_converter_;
27
28 DISALLOW_COPY_AND_ASSIGN(ActivityLogValueConverter);
29 };
30
31 } // namespace extensions
32
33 #endif // CHROME_RENDERER_EXTENSIONS_ACTIVITY_LOG_VALUE_CONVERTER_H_
felt 2013/07/18 17:28:20 linter is complaining about lack of a new line at
pmarch 2013/07/18 20:42:03 Done.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698