Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Side by Side Diff: chrome/renderer/extensions/dom_activity_logger.cc

Issue 19730002: V8ValueConverter for the activity logger that does not invoke interceptors and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Dan's comment Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/extensions/dom_activity_logger.h" 5 #include "chrome/renderer/extensions/dom_activity_logger.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "chrome/common/extensions/dom_action_types.h" 8 #include "chrome/common/extensions/dom_action_types.h"
9 #include "chrome/common/extensions/extension_messages.h" 9 #include "chrome/common/extensions/extension_messages.h"
10 #include "chrome/renderer/chrome_render_process_observer.h" 10 #include "chrome/renderer/chrome_render_process_observer.h"
11 #include "chrome/renderer/extensions/activity_log_converter_strategy.h"
11 #include "content/public/renderer/render_thread.h" 12 #include "content/public/renderer/render_thread.h"
12 #include "content/public/renderer/v8_value_converter.h" 13 #include "content/public/renderer/v8_value_converter.h"
13 #include "third_party/WebKit/public/platform/WebString.h" 14 #include "third_party/WebKit/public/platform/WebString.h"
14 #include "third_party/WebKit/public/web/WebDOMActivityLogger.h" 15 #include "third_party/WebKit/public/web/WebDOMActivityLogger.h"
15 #include "v8/include/v8.h" 16 #include "v8/include/v8.h"
16 17
17 using content::V8ValueConverter; 18 using content::V8ValueConverter;
18 19
19 namespace extensions { 20 namespace extensions {
20 21
21 DOMActivityLogger::DOMActivityLogger(const std::string& extension_id, 22 DOMActivityLogger::DOMActivityLogger(const std::string& extension_id,
22 const GURL& url, 23 const GURL& url,
23 const string16& title) 24 const string16& title)
24 : extension_id_(extension_id), url_(url), title_(title) { 25 : extension_id_(extension_id), url_(url), title_(title) {
25 } // namespace extensions 26 } // namespace extensions
26 27
27 void DOMActivityLogger::log( 28 void DOMActivityLogger::log(
28 const WebString& api_name, 29 const WebString& api_name,
29 int argc, 30 int argc,
30 const v8::Handle<v8::Value> argv[], 31 const v8::Handle<v8::Value> argv[],
31 const WebString& call_type) { 32 const WebString& call_type) {
32 scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create()); 33 scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
34 ActivityLogConverterStrategy strategy;
35 converter->SetFunctionAllowed(true);
36 converter->SetStrategy(&strategy);
33 scoped_ptr<ListValue> argv_list_value(new ListValue()); 37 scoped_ptr<ListValue> argv_list_value(new ListValue());
34 for (int i =0; i < argc; i++) { 38 for (int i =0; i < argc; i++) {
35 argv_list_value->Set( 39 argv_list_value->Set(
36 i, converter->FromV8Value(argv[i], v8::Context::GetCurrent())); 40 i, converter->FromV8Value(argv[i], v8::Context::GetCurrent()));
37 } 41 }
38 ExtensionHostMsg_DOMAction_Params params; 42 ExtensionHostMsg_DOMAction_Params params;
39 params.url = url_; 43 params.url = url_;
40 params.url_title = title_; 44 params.url_title = title_;
41 params.api_call = api_name.utf8(); 45 params.api_call = api_name.utf8();
42 params.arguments.Swap(argv_list_value.get()); 46 params.arguments.Swap(argv_list_value.get());
(...skipping 19 matching lines...) Expand all
62 // If there is no logger registered for world_id, construct a new logger 66 // If there is no logger registered for world_id, construct a new logger
63 // and register it with world_id. 67 // and register it with world_id.
64 if (!WebKit::hasDOMActivityLogger(world_id)) { 68 if (!WebKit::hasDOMActivityLogger(world_id)) {
65 DOMActivityLogger* logger = new DOMActivityLogger(extension_id, url, title); 69 DOMActivityLogger* logger = new DOMActivityLogger(extension_id, url, title);
66 WebKit::setDOMActivityLogger(world_id, logger); 70 WebKit::setDOMActivityLogger(world_id, logger);
67 } 71 }
68 } 72 }
69 73
70 } // namespace extensions 74 } // namespace extensions
71 75
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698