V8ValueConverter for the activity logger that does not invoke interceptors and

chrome/renderer/extensions/api_activity_logger.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include "base/bind.h"
 #include "chrome/common/extensions/extension_messages.h"
 #include "chrome/renderer/chrome_render_process_observer.h"
+#include "chrome/renderer/extensions/activity_log_converter_strategy.h"
 #include "chrome/renderer/extensions/api_activity_logger.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/v8_value_converter.h"
 
 using content::V8ValueConverter;
 
 namespace extensions {
 
 APIActivityLogger::APIActivityLogger(
     Dispatcher* dispatcher, ChromeV8Context* context)
@@ skipping 30 matching lines @@
   params.api_call = *v8::String::AsciiValue(args[1]);
   if (args.Length() == 4)  // Extras are optional.
     params.extra = *v8::String::AsciiValue(args[3]);
   else
     params.extra = "";
 
   // Get the array of api call arguments.
   v8::Local<v8::Array> arg_array = v8::Local<v8::Array>::Cast(args[2]);
   if (arg_array->Length() > 0) {
     scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
+    ActivityLogConverterStrategy strategy;
+    // Do not set the converter's RegExpr to true via SetRegExpAllowed() as this
+    // will call JS toString() method which can be overwritten.

[not at google - send to devlin, 2013/08/07 22:07:56]

RegExp seems a bit like an implementation detail. We could equally change
V8ValueConverter not to call ToString() on the regexp.

In fact you could change it to use GetSource().

All that aside - you're not disabling RegExp here anyway.

[pmarch, 2013/08/08 00:53:07]

I've decided to kill this comment

+    converter->SetFunctionAllowed(true);
+    converter->SetStrategy(&strategy);
     scoped_ptr<ListValue> arg_list(new ListValue());
     for (size_t i = 0; i < arg_array->Length(); ++i) {
       arg_list->Set(i,
                     converter->FromV8Value(arg_array->Get(i),
                     v8::Context::GetCurrent()));
     }
     params.arguments.Swap(arg_list.get());
   }
 
   if (call_type == APICALL) {
@@ skipping 30 matching lines @@
       result == Feature::INVALID_MAX_MANIFEST_VERSION ||
       result == Feature::UNSUPPORTED_CHANNEL)
     return;
   content::RenderThread::Get()->Send(
       new ExtensionHostMsg_AddBlockedCallToActivityLog(extension_id,
                                                        function_name));
 }
 
 
 }  // namespace extensions