third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html - Issue 1972943002: Modifies few gc related layout tests to work with ignition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

Issue 1972943002: Modifies few gc related layout tests to work with ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html ('K') | « third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers.html ('k') | third_party/WebKit/LayoutTests/fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

diff --git a/third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html b/third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

index 56760a6e3f18086073814f1a69da8fc6021bc9ae..cb368002ac7ca8877ecdde39aa99eb2741de6286 100644

--- a/third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

+++ b/third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html

@@ -20,10 +20,17 @@

function test(type)

{

- var doc = (new DOMParser).parseFromString("<html><body><span></span></body></html>", "text/xml");

- doc.getElementsByTagName("span")[0].foo = "PASS";

- var result = doc.evaluate("//span", doc.documentElement, null, type, null);

- doc = 0;

+ var doc, result;

+ function initialize() {

+ doc = (new DOMParser).parseFromString("<html><body><span></span></body></html>", "text/xml");

+ doc.getElementsByTagName("span")[0].foo = "PASS";

+ result = doc.evaluate("//span", doc.documentElement, null, type, null);

+ doc = 0;

+ }

+ // Perform all assignments in a function to avoid references to

+ // objects in dead registers when using ignition (chromium:595672)

+ initialize();

gc();

var console = document.getElementById("console");

console.appendChild(document.createTextNode(result.iterateNext().foo));