third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable.html - Issue 1972943002: Modifies few gc related layout tests to work with ignition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable.html

Issue 1972943002: Modifies few gc related layout tests to work with ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html ('K') | « third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html ('k') | third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable.html b/third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable.html

index 0016cb052d09153e56be04b4cbbb747cb2ab74b6..5f8b5bf608e9812c7e023fe57fb2757ed4ba31d1 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable.html

@@ -19,7 +19,9 @@ var nodeListKind = {

var i = 1;

for (var kind in nodeListKind) {

var code = nodeListKind[kind];

- eval(code).customProperty = i;

+ // Perform all assignments in a function to avoid references to objects

+ // in dead registers when using ignition (chromium:595672)

+ (() => {eval(code).customProperty = i})();

gc();

shouldBe(code + '.customProperty', '' + i++);

}