Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1972923003: media: Fix gn deps on media/test/* targets (Closed)

Created:
4 years, 7 months ago by jrummell
Modified:
4 years, 7 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Fix gn deps on media/test/* targets Add missing dependencies. BUG=599578 TEST=gn check //media/test/* is clean Committed: https://crrev.com/9864f223dead50dee4dd368c8e53b95a70cfb012 Cr-Commit-Position: refs/heads/master@{#393406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M media/test/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jrummell
PTAL.
4 years, 7 months ago (2016-05-12 19:01:30 UTC) #2
chcunningham
lgtm
4 years, 7 months ago (2016-05-12 23:23:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972923003/1
4 years, 7 months ago (2016-05-13 00:16:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 00:20:51 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 00:23:36 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9864f223dead50dee4dd368c8e53b95a70cfb012
Cr-Commit-Position: refs/heads/master@{#393406}

Powered by Google App Engine
This is Rietveld 408576698