[ios] Register test web schemes in WebTestSuite.

[ios] Register test web schemes in WebTestSuite.

BUG=610619
Committed: https://crrev.com/d195033a24b74413492685d93766932b64ad571e
Cr-Commit-Position: refs/heads/master@{#394159}

[Eugene But (OOO till 7-30), 2016-05-12 17:41:15]

eugenebut@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-05-17 09:29:43]

Can you send the CL to the bots to see if they are happy?

https://codereview.chromium.org/1972903003/diff/20001/ios/web/test/web_test.mm
File ios/web/test/web_test.mm (right):

https://codereview.chromium.org/1972903003/diff/20001/ios/web/test/web_test.m...
ios/web/test/web_test.mm:41: WebTest::WebTest() :
web_client_(base::WrapUnique(new TestWebClient)) {}
nit: I think you don't really need the base::WrapUnique here.

https://codereview.chromium.org/1972903003/diff/20001/ios/web/test/web_test_s...
File ios/web/test/web_test_suite.mm (right):

https://codereview.chromium.org/1972903003/diff/20001/ios/web/test/web_test_s...
ios/web/test/web_test_suite.mm:30: web_client_(base::WrapUnique(new
TestWebClient)) {}
nit: I think you don't really need the base::WrapUnique here.

[sdefresne, 2016-05-17 09:44:45]

lgtm provided that the bots are happy

[sdefresne, 2016-05-17 10:25:54]

not lgtm as you need to register the WebClient after creating it (and this is
why you should always send you CL to the try bots before asking for a review,
the bots would have caught this error).

Please also record the previous WebClient and restore it in WebTestSuite.

[Eugene But (OOO till 7-30), 2016-05-17 15:23:11]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 15:23:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972903003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972903003/20001

[Eugene But (OOO till 7-30), 2016-05-17 15:24:37]

On 2016/05/17 10:25:54, sdefresne wrote:
> not lgtm as you need to register the WebClient after creating it (and this is
> why you should always send you CL to the try bots before asking for a review,
> the bots would have caught this error).
> 
> Please also record the previous WebClient and restore it in WebTestSuite.
Not sure if I understand this comment. ScopedTestingWebClient registers
WebClient and restores the original on destruction. Am I missing something?

[commit-bot: I haz the power, 2016-05-17 16:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 16:24:19]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-05-17 16:41:42]

On 2016/05/17 15:24:37, Eugene But wrote:
> On 2016/05/17 10:25:54, sdefresne wrote:
> > not lgtm as you need to register the WebClient after creating it (and this
is
> > why you should always send you CL to the try bots before asking for a
review,
> > the bots would have caught this error).
> > 
> > Please also record the previous WebClient and restore it in WebTestSuite.
> Not sure if I understand this comment. ScopedTestingWebClient registers
> WebClient and restores the original on destruction. Am I missing something?

Ah sorry, didn't see that the code was using ScopedTestingWebClient, sorry.
lgtm

[Eugene But (OOO till 7-30), 2016-05-17 16:47:07]

On 2016/05/17 16:41:42, sdefresne wrote:
> On 2016/05/17 15:24:37, Eugene But wrote:
> > On 2016/05/17 10:25:54, sdefresne wrote:
> > > not lgtm as you need to register the WebClient after creating it (and this
> is
> > > why you should always send you CL to the try bots before asking for a
> review,
> > > the bots would have caught this error).
> > > 
> > > Please also record the previous WebClient and restore it in WebTestSuite.
> > Not sure if I understand this comment. ScopedTestingWebClient registers
> > WebClient and restores the original on destruction. Am I missing something?
> 
> Ah sorry, didn't see that the code was using ScopedTestingWebClient, sorry.
> lgtm

Thanks! Added comments to ivar.

[Eugene But (OOO till 7-30), 2016-05-17 16:47:11]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-05-17 16:47:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972903003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972903003/40001

[commit-bot: I haz the power, 2016-05-17 18:00:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-17 18:01:28]

Description was changed from

==========
[ios] Register test web schemes in WebTestSuite.

BUG=610619
==========

to

==========
[ios] Register test web schemes in WebTestSuite.

BUG=610619

Committed: https://crrev.com/d195033a24b74413492685d93766932b64ad571e
Cr-Commit-Position: refs/heads/master@{#394159}
==========

[commit-bot: I haz the power, 2016-05-17 18:01:29]

Patchset 3 (id:??) landed as
https://crrev.com/d195033a24b74413492685d93766932b64ad571e
Cr-Commit-Position: refs/heads/master@{#394159}