Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 19729003: Fix NaCl regression caused by pepper revision 28. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Brad Chen (chromium)
Visibility:
Public.

Description

Fix NaCl regression caused by pepper revision 28. Patch from bradchen@chromium.org. Prevents use of PROT_EXEC for NaCl builds R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/deoptimizer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/platform-linux.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-18 12:13:45 UTC) #1
Benedikt Meurer
lgtm
7 years, 5 months ago (2013-07-18 12:14:09 UTC) #2
Michael Achenbach
7 years, 5 months ago (2013-07-18 12:18:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698