Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19729002: Introduce toSVGGradientElement(), use it (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive
Modified:
7 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toSVGGradientElement(), use it As a step to change static_cast with toSVGXXX, static_cast<SVGGradientElement*> can be changed with toSVGGradientElement(). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154610

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Source/core/rendering/svg/RenderSVGGradientStop.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
gyuyoung-inactive
Add tkent as reviewer.
7 years, 5 months ago (2013-07-18 05:34:33 UTC) #1
tkent
https://codereview.chromium.org/19729002/diff/2001/Source/core/svg/SVGGradientElement.h File Source/core/svg/SVGGradientElement.h (right): https://codereview.chromium.org/19729002/diff/2001/Source/core/svg/SVGGradientElement.h#newcode111 Source/core/svg/SVGGradientElement.h:111: ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::radialGradientTag)); Looks wrong. We should accept SVGNames::linearGradientTag ...
7 years, 5 months ago (2013-07-18 05:47:15 UTC) #2
gyuyoung-inactive
On 2013/07/18 05:47:15, tkent wrote: > https://codereview.chromium.org/19729002/diff/2001/Source/core/svg/SVGGradientElement.h#newcode111 > Source/core/svg/SVGGradientElement.h:111: ASSERT_WITH_SECURITY_IMPLICATION(!node > || node->hasTagName(SVGNames::radialGradientTag)); > Looks ...
7 years, 5 months ago (2013-07-18 05:54:08 UTC) #3
tkent
lgtm
7 years, 5 months ago (2013-07-18 06:10:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19729002/7001
7 years, 5 months ago (2013-07-18 06:11:14 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-18 06:26:27 UTC) #6
tkent
Did you upload a patch without building?
7 years, 5 months ago (2013-07-18 06:28:26 UTC) #7
gyuyoung-inactive
On 2013/07/18 06:28:26, tkent wrote: > Did you upload a patch without building? no, I ...
7 years, 5 months ago (2013-07-18 23:06:17 UTC) #8
tkent
On 2013/07/18 23:06:17, gyuyoung wrote: > On 2013/07/18 06:28:26, tkent wrote: > > Did you ...
7 years, 5 months ago (2013-07-18 23:34:44 UTC) #9
gyuyoung-inactive
On 2013/07/18 23:34:44, tkent wrote: > Are you using Release build? Developers should use Debug ...
7 years, 5 months ago (2013-07-19 02:40:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19729002/23001
7 years, 5 months ago (2013-07-19 02:41:35 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests ...
7 years, 5 months ago (2013-07-19 05:48:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19729002/23001
7 years, 5 months ago (2013-07-19 08:16:38 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=83
7 years, 5 months ago (2013-07-19 12:52:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19729002/47001
7 years, 5 months ago (2013-07-20 09:49:21 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests, wtf_unittests ...
7 years, 5 months ago (2013-07-20 10:02:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/19729002/53004
7 years, 5 months ago (2013-07-21 09:00:10 UTC) #17
commit-bot: I haz the power
7 years, 5 months ago (2013-07-21 11:25:06 UTC) #18
Message was sent while issue was closed. 
Change committed as 154610

Powered by Google App Engine
This is Rietveld 408576698