Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Issue 19729: Reduce flakiness of condition var unit test (Closed)

Created:
11 years, 10 months ago by jar (doing other things)
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Reduce flakiness of condition var unit test by reducing timing dependence. Re-enable test, with hopes that external changes plus my changes reduce flakyness sufficiently. Also switch to using standard sleep method for better readability. bug=3599 r=mark Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13557

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -40 lines) Patch
M base/condition_variable_unittest.cc View 1 2 3 4 5 6 10 chunks +75 lines, -40 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jar (doing other things)
11 years, 8 months ago (2009-04-10 23:17:55 UTC) #1
Mark Mentovai
11 years, 8 months ago (2009-04-11 01:19:08 UTC) #2
Looks good.

Powered by Google App Engine
This is Rietveld 408576698