Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 197283036: Oilpan: have WebPerformance use transition types. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: have WebPerformance use transition types. Also have DOMWindow keep a persistent reference to its Performance object. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPerformance.cpp View 1 chunk +2 lines, -7 lines 0 comments Download
M public/web/WebPerformance.h View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look. Small followup on moving Performance over to oilpan'ed types. (needs public/ ...
6 years, 9 months ago (2014-03-19 08:09:25 UTC) #1
tkent
lgtm
6 years, 9 months ago (2014-03-19 08:20:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/197283036/1
6 years, 9 months ago (2014-03-19 08:20:47 UTC) #3
haraken
LGTM
6 years, 9 months ago (2014-03-19 08:30:16 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 09:02:30 UTC) #5
Message was sent while issue was closed.
Change committed as 169532

Powered by Google App Engine
This is Rietveld 408576698