Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: Source/devtools/front_end/DOMAgent.js

Issue 197283031: DevTools: fix author shadow dom inspection mode, speacial-case ua. Fix crash from the bug. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/devtools/front_end/ElementsPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/DOMAgent.js
diff --git a/Source/devtools/front_end/DOMAgent.js b/Source/devtools/front_end/DOMAgent.js
index 6a2ccbb479ce1152c16e585fa160d5c6d7c6117a..b0c400dca0579c816f17ca8a9216138f18c33b47 100644
--- a/Source/devtools/front_end/DOMAgent.js
+++ b/Source/devtools/front_end/DOMAgent.js
@@ -1321,17 +1321,17 @@ WebInspector.DOMAgent.prototype = {
/**
* @param {boolean} enabled
- * @param {boolean} inspectShadowDOM
+ * @param {boolean} inspectUAShadowDOM
* @param {function(?Protocol.Error)=} callback
*/
- setInspectModeEnabled: function(enabled, inspectShadowDOM, callback)
+ setInspectModeEnabled: function(enabled, inspectUAShadowDOM, callback)
{
/**
* @this {WebInspector.DOMAgent}
*/
function onDocumentAvailable()
{
- this._highlighter.setInspectModeEnabled(enabled, inspectShadowDOM, this._buildHighlightConfig(), callback);
+ this._highlighter.setInspectModeEnabled(enabled, inspectUAShadowDOM, this._buildHighlightConfig(), callback);
}
this.requestDocument(onDocumentAvailable.bind(this));
},
@@ -1631,11 +1631,11 @@ WebInspector.DOMNodeHighlighter.prototype = {
/**
* @param {boolean} enabled
- * @param {boolean} inspectShadowDOM
+ * @param {boolean} inspectUAShadowDOM
* @param {!DOMAgent.HighlightConfig} config
* @param {function(?Protocol.Error)=} callback
*/
- setInspectModeEnabled: function(enabled, inspectShadowDOM, config, callback) {}
+ setInspectModeEnabled: function(enabled, inspectUAShadowDOM, config, callback) {}
}
/**
@@ -1661,13 +1661,13 @@ WebInspector.DefaultDOMNodeHighlighter.prototype = {
/**
* @param {boolean} enabled
- * @param {boolean} inspectShadowDOM
+ * @param {boolean} inspectUAShadowDOM
* @param {!DOMAgent.HighlightConfig} config
* @param {function(?Protocol.Error)=} callback
*/
- setInspectModeEnabled: function(enabled, inspectShadowDOM, config, callback)
+ setInspectModeEnabled: function(enabled, inspectUAShadowDOM, config, callback)
{
- DOMAgent.setInspectModeEnabled(enabled, inspectShadowDOM, config, callback);
+ DOMAgent.setInspectModeEnabled(enabled, inspectUAShadowDOM, config, callback);
}
}
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/devtools/front_end/ElementsPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698