Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Side by Side Diff: Source/devtools/front_end/ScreencastView.js

Issue 197283031: DevTools: fix author shadow dom inspection mode, speacial-case ua. Fix crash from the bug. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
716 _viewportDimensions: function() 716 _viewportDimensions: function()
717 { 717 {
718 const gutterSize = 30; 718 const gutterSize = 30;
719 const bordersSize = WebInspector.ScreencastView._bordersSize; 719 const bordersSize = WebInspector.ScreencastView._bordersSize;
720 return { width: this.element.offsetWidth - bordersSize - gutterSize, 720 return { width: this.element.offsetWidth - bordersSize - gutterSize,
721 height: this.element.offsetHeight - bordersSize - gutterSize - WebInspector.ScreencastView._navBarHeight}; 721 height: this.element.offsetHeight - bordersSize - gutterSize - WebInspector.ScreencastView._navBarHeight};
722 }, 722 },
723 723
724 /** 724 /**
725 * @param {boolean} enabled 725 * @param {boolean} enabled
726 * @param {boolean} inspectShadowDOM 726 * @param {boolean} inspectUAShadowDOM
727 * @param {!DOMAgent.HighlightConfig} config 727 * @param {!DOMAgent.HighlightConfig} config
728 * @param {function(?Protocol.Error)=} callback 728 * @param {function(?Protocol.Error)=} callback
729 */ 729 */
730 setInspectModeEnabled: function(enabled, inspectShadowDOM, config, callback) 730 setInspectModeEnabled: function(enabled, inspectUAShadowDOM, config, callbac k)
731 { 731 {
732 this._inspectModeConfig = enabled ? config : null; 732 this._inspectModeConfig = enabled ? config : null;
733 if (callback) 733 if (callback)
734 callback(null); 734 callback(null);
735 }, 735 },
736 736
737 /** 737 /**
738 * @param {!CanvasRenderingContext2D} context 738 * @param {!CanvasRenderingContext2D} context
739 */ 739 */
740 _createCheckerboardPattern: function(context) 740 _createCheckerboardPattern: function(context)
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
988 * @return {!Element} 988 * @return {!Element}
989 */ 989 */
990 statusBarItem: function() 990 statusBarItem: function()
991 { 991 {
992 if (this._initialized) 992 if (this._initialized)
993 return this._toggleScreencastButton.element; 993 return this._toggleScreencastButton.element;
994 this._statusBarPlaceholder = document.createElement("div"); 994 this._statusBarPlaceholder = document.createElement("div");
995 return this._statusBarPlaceholder; 995 return this._statusBarPlaceholder;
996 } 996 }
997 }; 997 };
OLDNEW
« no previous file with comments | « Source/devtools/front_end/InspectElementModeController.js ('k') | Source/devtools/front_end/Settings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698