Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197283031: DevTools: fix author shadow dom inspection mode, speacial-case ua. Fix crash from the bug. (Closed)

Created:
6 years, 9 months ago by pfeldman
Modified:
6 years, 9 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: fix author shadow dom inspection mode, speacial-case ua. Fix crash from the bug. R=apavlov BUG=353016 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169441

Patch Set 1 #

Total comments: 4

Patch Set 2 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -48 lines) Patch
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-restart.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/template-content-inspect-crash.html View 2 chunks +1 line, -3 lines 0 comments Download
M LayoutTests/inspector/console/shadow-element.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/breadcrumb-shadow-roots.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/inspector/elements/inspect-mode-shadow-text.html View 1 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/inspect-mode-shadow-text-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/inspector/elements/reveal-shadow-dom-node.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/shadow-dom-modify-chardata.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/shadow-dom-rules.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/elements/update-shadowdom.html View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 5 chunks +34 lines, -9 lines 0 comments Download
M Source/devtools/front_end/DOMAgent.js View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/ElementsPanel.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ElementsTreeOutline.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/InspectElementModeController.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ScreencastView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 chunk +1 line, -4 lines 0 comments Download
M Source/devtools/front_end/SettingsScreen.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
pfeldman
6 years, 9 months ago (2014-03-18 08:27:56 UTC) #1
apavlov
lgtm https://codereview.chromium.org/197283031/diff/1/LayoutTests/inspector/elements/inspect-mode-shadow-text.html File LayoutTests/inspector/elements/inspect-mode-shadow-text.html (right): https://codereview.chromium.org/197283031/diff/1/LayoutTests/inspector/elements/inspect-mode-shadow-text.html#newcode22 LayoutTests/inspector/elements/inspect-mode-shadow-text.html:22: WebInspector.inspectorView.showPanel("elements"); optional: I've seen fast/ tests using eventSender ...
6 years, 9 months ago (2014-03-18 08:49:38 UTC) #2
pfeldman
https://codereview.chromium.org/197283031/diff/1/LayoutTests/inspector/elements/inspect-mode-shadow-text.html File LayoutTests/inspector/elements/inspect-mode-shadow-text.html (right): https://codereview.chromium.org/197283031/diff/1/LayoutTests/inspector/elements/inspect-mode-shadow-text.html#newcode22 LayoutTests/inspector/elements/inspect-mode-shadow-text.html:22: WebInspector.inspectorView.showPanel("elements"); On 2014/03/18 08:49:39, apavlov wrote: > Won't the ...
6 years, 9 months ago (2014-03-18 09:15:45 UTC) #3
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 9 months ago (2014-03-18 09:15:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/197283031/20001
6 years, 9 months ago (2014-03-18 09:16:00 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 10:18:32 UTC) #6
Message was sent while issue was closed. 
Change committed as 169441

Powered by Google App Engine
This is Rietveld 408576698