src/ic.cc - Issue 197283017: Refactor GetCodeCopyFromTemplate to get a single point where objects are replaced in code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 197283017: Refactor GetCodeCopyFromTemplate to get a single point where objects are replaced in code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index f1e3c5539d64fbd9f74cc0de671edc62a2cb3db6..5e75b8dbfcb53c3b37b1b75479c5bfa606f6e771 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1369,7 +1369,7 @@ Handle<Code> StoreIC::CompileHandler(LookupResult* lookup,

StoreGlobalStub stub(

union_type->IsConstant(), receiver->IsJSGlobalProxy());

Handle<Code> code = stub.GetCodeCopyFromTemplate(

- isolate(), *global, *cell);

+ isolate(), global, cell);

ulan 2014/03/14 16:15:59 Passing raw pointers was a bug as GetCodeCopyFromT

Toon Verwaest 2014/03/17 09:40:14 Nice catch! On 2014/03/14 16:15:59, ulan wrote:

// TODO(verwaest): Move caching of these NORMAL stubs outside as well.

HeapObject::UpdateMapCodeCache(receiver, name, code);

return code;

« no previous file with comments | « src/code-stubs.cc ('k') | src/objects.h » ('j') | src/objects.cc » ('J')