Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/ic.cc

Issue 197283017: Refactor GetCodeCopyFromTemplate to get a single point where objects are replaced in code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1351 matching lines...) Expand 10 before | Expand all | Expand 10 after
1362 // from the property cell. So the property must be directly on the 1362 // from the property cell. So the property must be directly on the
1363 // global object. 1363 // global object.
1364 Handle<GlobalObject> global = receiver->IsJSGlobalProxy() 1364 Handle<GlobalObject> global = receiver->IsJSGlobalProxy()
1365 ? handle(GlobalObject::cast(receiver->GetPrototype())) 1365 ? handle(GlobalObject::cast(receiver->GetPrototype()))
1366 : Handle<GlobalObject>::cast(receiver); 1366 : Handle<GlobalObject>::cast(receiver);
1367 Handle<PropertyCell> cell(global->GetPropertyCell(lookup), isolate()); 1367 Handle<PropertyCell> cell(global->GetPropertyCell(lookup), isolate());
1368 Handle<HeapType> union_type = PropertyCell::UpdatedType(cell, value); 1368 Handle<HeapType> union_type = PropertyCell::UpdatedType(cell, value);
1369 StoreGlobalStub stub( 1369 StoreGlobalStub stub(
1370 union_type->IsConstant(), receiver->IsJSGlobalProxy()); 1370 union_type->IsConstant(), receiver->IsJSGlobalProxy());
1371 Handle<Code> code = stub.GetCodeCopyFromTemplate( 1371 Handle<Code> code = stub.GetCodeCopyFromTemplate(
1372 isolate(), *global, *cell); 1372 isolate(), global, cell);
1373 // TODO(verwaest): Move caching of these NORMAL stubs outside as well. 1373 // TODO(verwaest): Move caching of these NORMAL stubs outside as well.
1374 HeapObject::UpdateMapCodeCache(receiver, name, code); 1374 HeapObject::UpdateMapCodeCache(receiver, name, code);
1375 return code; 1375 return code;
1376 } 1376 }
1377 ASSERT(holder.is_identical_to(receiver)); 1377 ASSERT(holder.is_identical_to(receiver));
1378 return isolate()->builtins()->StoreIC_Normal(); 1378 return isolate()->builtins()->StoreIC_Normal();
1379 case CALLBACKS: { 1379 case CALLBACKS: {
1380 Handle<Object> callback(lookup->GetCallbackObject(), isolate()); 1380 Handle<Object> callback(lookup->GetCallbackObject(), isolate());
1381 if (callback->IsExecutableAccessorInfo()) { 1381 if (callback->IsExecutableAccessorInfo()) {
1382 Handle<ExecutableAccessorInfo> info = 1382 Handle<ExecutableAccessorInfo> info =
(...skipping 1458 matching lines...) Expand 10 before | Expand all | Expand 10 after
2841 #undef ADDR 2841 #undef ADDR
2842 }; 2842 };
2843 2843
2844 2844
2845 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2845 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2846 return IC_utilities[id]; 2846 return IC_utilities[id];
2847 } 2847 }
2848 2848
2849 2849
2850 } } // namespace v8::internal 2850 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698