Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 197283016: Revert node.contains to the original behavior. (Closed)

Created:
6 years, 9 months ago by hayato
Modified:
6 years, 9 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Revert node.contains to the original behavior. The node.contains changed the behavior in https://chromiumcodereview.appspot.com/21123005 We don't have any spec for that. Until we have a wider consensus, it should be better to revert the change. It is not wise to leave this change as is because it doesn't follow the semantics of node.contains defined in DOM living standard. http://dom.spec.whatwg.org/#dom-node-contains This is discussed on this W3 bug: <https://www.w3.org/Bugs/Public/show_bug.cgi?id=22141>; Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M LayoutTests/fast/dom/shadow/contains-with-shadow-dom.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/shadow/contains-with-shadow-dom-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
hayato
6 years, 9 months ago (2014-03-14 09:17:20 UTC) #1
esprehn
Since we have ShadowRoot.host now you can implement your own tree traversal and answer the ...
6 years, 9 months ago (2014-03-15 02:13:08 UTC) #2
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-15 02:21:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/197283016/1
6 years, 9 months ago (2014-03-15 02:21:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-15 02:21:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-15 02:21:42 UTC) #6
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-15 02:21:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/197283016/1
6 years, 9 months ago (2014-03-15 02:22:01 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-15 03:03:26 UTC) #9
Message was sent while issue was closed.
Change committed as 169296

Powered by Google App Engine
This is Rietveld 408576698