Update common.gypi to set clang=1 for all iOS builds.

Update common.gypi to set clang=1 for all iOS builds.

All iOS builds now use clang, regardless of which gyp generator is used, so
change common.gypi to reflect that.

NOTRY=True
BUG=352167
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256923

[rohitrao (ping after 24h), 2014-03-13 15:36:22]

This turned out to be much smaller than I was expecting.

There are "clang==1" conditions in ~20 other gyp files, but I looked at all of
them and they're just adding or removing various warning flags.  I don't expect
them to cause problems on iOS.

[Nico, 2014-03-13 15:43:37]

lgtm as far as I can tell.

Thanks!

https://codereview.chromium.org/197283006/diff/40001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/197283006/diff/40001/build/common.gypi#newcod...
build/common.gypi:1534: # Enable clang on mac by default!  All iOS builds
already use clang.
nit: This comment can probably go away. It was (maybe) useful when clang being
on by default was noteworthy, but that was long ago.

[Mark Mentovai, 2014-03-13 15:56:04]

LGTM

[rohitrao (ping after 24h), 2014-03-13 16:30:49]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2014-03-13 16:32:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/197283006/40001

[commit-bot: I haz the power, 2014-03-13 19:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-13 19:47:30]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[rohitrao (ping after 24h), 2014-03-13 20:31:56]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2014-03-13 20:33:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/197283006/40001

[rohitrao (ping after 24h), 2014-03-13 20:37:24]

The CQ bit was unchecked by rohitrao@chromium.org

[rohitrao (ping after 24h), 2014-03-13 20:39:27]

Adding NOTRY=True because I've hit four broken win_rel bots in a row, two of
those bots compiled successfully, and my changes are entirely within "mac" or
"ios" blocks.

[rohitrao (ping after 24h), 2014-03-13 20:39:31]

The CQ bit was checked by rohitrao@chromium.org

[Nico, 2014-03-13 20:40:46]

(Doesn't that invalidate your argument for ignoring my comment?)

[commit-bot: I haz the power, 2014-03-13 20:41:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/197283006/40001

[commit-bot: I haz the power, 2014-03-13 20:46:03]

Change committed as 256923