Chromium Code Reviews| Index: runtime/vm/intermediate_language.cc |
| =================================================================== |
| --- runtime/vm/intermediate_language.cc (revision 33576) |
| +++ runtime/vm/intermediate_language.cc (working copy) |
| @@ -2062,17 +2062,20 @@ |
| LocationSummary* DropTempsInstr::MakeLocationSummary(bool optimizing) const { |
| - return LocationSummary::Make(1, |
| - Location::SameAsFirstInput(), |
| - LocationSummary::kNoCall); |
| + return (value() != NULL) |
|
srdjan
2014/03/12 18:18:30
InputCount() == 0 seems more readable.
Florian Schneider
2014/03/13 08:56:15
Done.
|
| + ? LocationSummary::Make(1, |
| + Location::SameAsFirstInput(), |
| + LocationSummary::kNoCall) |
| + : LocationSummary::Make(0, |
| + Location::NoLocation(), |
| + LocationSummary::kNoCall); |
| } |
| void DropTempsInstr::EmitNativeCode(FlowGraphCompiler* compiler) { |
| ASSERT(!compiler->is_optimizing()); |
| - Register value = locs()->in(0).reg(); |
| - Register result = locs()->out().reg(); |
| - ASSERT(result == value); // Assert that register assignment is correct. |
| + // Assert that register assignment is correct. |
| + ASSERT((value() == NULL) || locs()->out().reg() == locs()->in(0).reg()); |
|
srdjan
2014/03/12 18:18:30
ditto
Florian Schneider
2014/03/13 08:56:15
Done.
|
| __ Drop(num_temps()); |
| } |