Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 19728003: Use C++11 deleted functions feature if available. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Visibility:
Public.

Description

Use C++11 deleted functions feature if available. Implement DISALLOW_COPY_AND_ASSIGN and DISALLOW_IMPLICIT_CONSTRUCTORS using C++11 deleted functions if possible. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15742

Patch Set 1 #

Patch Set 2 : Just check for C++ version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/globals.h View 1 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-18 06:46:46 UTC) #1
Sven Panne
lgtm
7 years, 5 months ago (2013-07-18 09:24:38 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-18 09:25:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15742 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698