Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: remoting/signaling/telemetry_log_writer.h

Issue 1972793002: TelemetryLogWriter cleanups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's Feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/signaling/chromoting_event_log_writer.h ('k') | remoting/signaling/telemetry_log_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/signaling/telemetry_log_writer.h
diff --git a/remoting/signaling/telemetry_log_writer.h b/remoting/signaling/telemetry_log_writer.h
deleted file mode 100644
index c6ec3da67aadfec5ee480e7fd56a3a4fa139c43c..0000000000000000000000000000000000000000
--- a/remoting/signaling/telemetry_log_writer.h
+++ /dev/null
@@ -1,71 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef REMOTING_SIGNALING_TELEMETRY_LOG_WRITER_H_
-#define REMOTING_SIGNALING_TELEMETRY_LOG_WRITER_H_
-
-#include <deque>
-#include <string>
-
-#include "base/callback.h"
-#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
-#include "base/threading/non_thread_safe.h"
-#include "base/values.h"
-#include "remoting/base/url_request.h"
-#include "remoting/signaling/chromoting_event.h"
-#include "remoting/signaling/chromoting_event_log_writer.h"
-
-namespace remoting {
-
-// TelemetryLogWriter sends log entries (ChromotingEvent) to the telemetry
-// server.
-// Logs to be sent will be queued and sent when it is available. Logs failed
-// to send will be retried for a few times and dropped if they still can't be
-// sent.
-class TelemetryLogWriter : public ChromotingEventLogWriter,
- public base::NonThreadSafe {
- public:
- TelemetryLogWriter(const std::string& telemetry_base_url,
- std::unique_ptr<UrlRequestFactory> request_factory);
-
- // "Authorization:Bearer {TOKEN}" will be added if auth_token is not empty.
- // After this function is called, the log writer will try to send out pending
- // logs if the list is not empty.
- void SetAuthToken(const std::string& auth_token) override;
-
- // The closure will be called when the request fails with unauthorized error
- // code. The closure should call SetAuthToken to set the token.
- // If the closure is not set, the log writer will try to resend the logs
- // immediately.
- void SetAuthClosure(const base::Closure& closure) override;
-
- // Push the log entry to the pending list and send out all the pending logs.
- void Log(const ChromotingEvent& entry) override;
-
- ~TelemetryLogWriter() override;
-
- private:
- void SendPendingEntries();
- void PostJsonToServer(const std::string& json);
- void OnSendLogResult(const remoting::UrlRequest::Result& result);
-
- std::string telemetry_base_url_;
- std::unique_ptr<UrlRequestFactory> request_factory_;
- std::string auth_token_;
- base::Closure auth_closure_;
- std::unique_ptr<UrlRequest> request_;
-
- // Entries to be sent.
- std::deque<ChromotingEvent> pending_entries_;
-
- // Entries being sent.
- // These will be pushed back to pending_entries if error occurs.
- std::deque<ChromotingEvent> sending_entries_;
-
- DISALLOW_COPY_AND_ASSIGN(TelemetryLogWriter);
-};
-
-} // namespace remoting
-#endif // REMOTING_SIGNALING_TELEMETRY_LOG_WRITER_H_
« no previous file with comments | « remoting/signaling/chromoting_event_log_writer.h ('k') | remoting/signaling/telemetry_log_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698