TelemetryLogWriter cleanups

TelemetryLogWriter cleanups

* Moved to base since it doesn't do anything related to signaling.
* Logs failed to send will be added to the front of the pending queue to maintain the chronological order.
* Addressed comments from sergeyu@.

BUG=546735
Committed: https://crrev.com/6269469228e11bc93ded9528df7f72f5e7d9e912
Cr-Commit-Position: refs/heads/master@{#393426}

[Yuwei, 2016-05-12 01:22:10]

Patchset #1 (id:1) has been deleted

[Yuwei, 2016-05-12 01:22:19]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 01:22:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972793002/20001

[Yuwei, 2016-05-12 01:23:38]

yuweih@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Yuwei, 2016-05-12 01:23:38]

This CL reorganizes the writer a bit and resolves comments in 1907343003. ptal

[commit-bot: I haz the power, 2016-05-12 03:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 03:12:42]

Dry run: This issue passed the CQ dry run.

[Yuwei, 2016-05-12 19:23:42]

The CQ bit was checked by yuweih@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 19:24:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972793002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972793002/40001

[commit-bot: I haz the power, 2016-05-12 20:25:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 20:25:25]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-05-12 22:48:05]

For the future: it's better to keep move CLs separate from other changes. Not a
big issue here, so LGTM once my nits are addressed.

https://codereview.chromium.org/1972793002/diff/40001/remoting/base/telemetry...
File remoting/base/telemetry_log_writer.cc (right):

https://codereview.chromium.org/1972793002/diff/40001/remoting/base/telemetry...
remoting/base/telemetry_log_writer.cc:95: ChromotingEvent& entry = *i;
Don't need this. Just use *i below.

https://codereview.chromium.org/1972793002/diff/40001/remoting/base/telemetry...
remoting/base/telemetry_log_writer.cc:96: if (entry.send_attempts() <
kMaxSendAttempts) {
replace this with
 if (entry.send_attempts() >= kMaxSendAttempts)
   break;
The log entries are in chronological order, so everything before current one can
be dropped as well.

[Yuwei, 2016-05-13 00:40:46]

Thanks for pointing out the moving file thing! I'll be careful in the future.

https://codereview.chromium.org/1972793002/diff/40001/remoting/base/telemetry...
File remoting/base/telemetry_log_writer.cc (right):

https://codereview.chromium.org/1972793002/diff/40001/remoting/base/telemetry...
remoting/base/telemetry_log_writer.cc:95: ChromotingEvent& entry = *i;
On 2016/05/12 22:48:05, Sergey Ulanov wrote:
> Don't need this. Just use *i below.

Done.

https://codereview.chromium.org/1972793002/diff/40001/remoting/base/telemetry...
remoting/base/telemetry_log_writer.cc:96: if (entry.send_attempts() <
kMaxSendAttempts) {
On 2016/05/12 22:48:04, Sergey Ulanov wrote:
> replace this with
>  if (entry.send_attempts() >= kMaxSendAttempts)
>    break;
> The log entries are in chronological order, so everything before current one
can
> be dropped as well.

Done. Good catch :)

[Yuwei, 2016-05-13 00:41:03]

The CQ bit was checked by yuweih@chromium.org

[Yuwei, 2016-05-13 00:41:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1972793002/#ps60001
(title: "Reviewer's Feedback")

[commit-bot: I haz the power, 2016-05-13 00:41:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972793002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972793002/60001

[commit-bot: I haz the power, 2016-05-13 01:56:12]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-13 01:58:24]

Description was changed from

==========
TelemetryLogWriter cleanups

* Moved to base since it doesn't do anything related to signaling.
* Logs failed to send will be added to the front of the pending queue to
maintain the chronological order.
* Addressed comments from sergeyu@.

BUG=546735
==========

to

==========
TelemetryLogWriter cleanups

* Moved to base since it doesn't do anything related to signaling.
* Logs failed to send will be added to the front of the pending queue to
maintain the chronological order.
* Addressed comments from sergeyu@.

BUG=546735

Committed: https://crrev.com/6269469228e11bc93ded9528df7f72f5e7d9e912
Cr-Commit-Position: refs/heads/master@{#393426}
==========

[commit-bot: I haz the power, 2016-05-13 01:58:25]

Patchset 3 (id:??) landed as
https://crrev.com/6269469228e11bc93ded9528df7f72f5e7d9e912
Cr-Commit-Position: refs/heads/master@{#393426}