Disable idle suspend for Chromecast

media/base/pipeline_impl.cc

Index: media/base/pipeline_impl.cc
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc
index e282a5e7f57eea8399c3b8e992ee6e075c7b9610..78b11ecbd784f3e6a262694af66606838adca40a 100644
--- a/media/base/pipeline_impl.cc
+++ b/media/base/pipeline_impl.cc
@@ -246,6 +246,12 @@ void PipelineImpl::SetCdm(CdmContext* cdm_context,
                             cdm_attached_cb));
 }
 
+bool PipelineImpl::CanSuspend() const {
+  DCHECK(media_task_runner_->BelongsToCurrentThread());
+  DCHECK(renderer_);

[sandersd (OOO until July 31), 2016/05/23 18:41:58]

Since CanSuspend() can be called before Start(), and while suspended, there
should be a default return value when there is no |renderer_|. It should be safe
to always return true.

Another implementation option (and an overall cleaner one, in terms of removing
|pipeline_| from WMPI) is to handle that fallback in PipelineController, which
unlike PipelineImpl is spec'd to return meaningful values before Start().

Actually testing |renderer_| isn't thread safe though, the pointer gets changed
on the media thread. Additional locking may be required.

[alokp, 2016/05/23 20:32:01]

I am also working on a patch that moves the renderer_ field into an internal
class that runs on the media thread. This patch is supposed to eliminate all
locking and waitable events from PipelineImpl:
https://codereview.chromium.org/1999893004/

+  return renderer_->AllowSuspend();
+}
+
 void PipelineImpl::SetErrorForTesting(PipelineStatus status) {
   OnError(status);
 }