Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1859)

Unified Diff: appengine/logdog/coordinator/endpoints/services/registerStream_test.go

Issue 1972753002: LogDog: Implement prefix expiration. (Closed) Base URL: https://github.com/luci/luci-go@logdog-butler-register-coordinator-impl
Patch Set: Updated patchset dependency Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/logdog/coordinator/endpoints/services/registerStream_test.go
diff --git a/appengine/logdog/coordinator/endpoints/services/registerStream_test.go b/appengine/logdog/coordinator/endpoints/services/registerStream_test.go
index 8149d5a5c1b49ff1f5029d5089136f10753a7378..912f32791fdaf6f6c3c71c45919564c37b6390e8 100644
--- a/appengine/logdog/coordinator/endpoints/services/registerStream_test.go
+++ b/appengine/logdog/coordinator/endpoints/services/registerStream_test.go
@@ -220,6 +220,13 @@ func TestRegisterStream(t *testing.T) {
})
Convey(`Registration failure cases`, func() {
+ Convey(`Will not register a stream if its prefix has expired.`, func() {
+ env.Clock.Set(tls.Prefix.Expiration)
+
+ _, err := svr.RegisterStream(c, &req)
+ So(err, ShouldBeRPCFailedPrecondition, "prefix has expired")
+ })
+
Convey(`Will not register a stream without a protobuf version.`, func() {
req.ProtoVersion = ""
_, err := svr.RegisterStream(c, &req)
« no previous file with comments | « appengine/logdog/coordinator/endpoints/services/registerStream.go ('k') | appengine/logdog/coordinator/logPrefix.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698