Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1972733002: Delete geofencing implementation. (Closed)

Created:
4 years, 7 months ago by Marijn Kruisselbrink
Modified:
4 years, 7 months ago
Reviewers:
haraken, Mike West, jam, Mark P
CC:
abarth-chromium, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chasej+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, falken, horo+watch_chromium.org, iclelland+watch_chromium.org, jam, jkarlin+watch_chromium.org, jochen+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+watch, kinuko+serviceworker, markusheintz_, michaeln, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, msramek+watch_chromium.org, nasko+codewatch_chromium.org, nhiroki, Peter Beverloo, serviceworker-reviews, tzik, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete geofencing implementation. We've decided that this API is not the right approach to solve the use cases we care about, so delete the implementation. BUG=383125 Committed: https://crrev.com/e078907f62cb060ddd19fe3dddea3e2142c0f7d8 Cr-Commit-Position: refs/heads/master@{#393597}

Patch Set 1 #

Patch Set 2 : fix test expectations #

Total comments: 2

Patch Set 3 : mark histogram suffix as obsolete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4138 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/test_runner/test_runner.h View 1 chunk +0 lines, -11 lines 0 comments Download
M components/test_runner/test_runner.cc View 1 2 7 chunks +0 lines, -38 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/DEPS View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D content/browser/geofencing/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/geofencing/geofencing_dispatcher_host.h View 1 chunk +0 lines, -61 lines 0 comments Download
D content/browser/geofencing/geofencing_dispatcher_host.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D content/browser/geofencing/geofencing_manager.h View 1 chunk +0 lines, -217 lines 0 comments Download
D content/browser/geofencing/geofencing_manager.cc View 1 chunk +0 lines, -442 lines 0 comments Download
D content/browser/geofencing/geofencing_manager_unittest.cc View 1 chunk +0 lines, -518 lines 0 comments Download
D content/browser/geofencing/geofencing_provider.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/browser/geofencing/geofencing_registration_delegate.h View 1 chunk +0 lines, -32 lines 0 comments Download
D content/browser/geofencing/geofencing_service.h View 1 chunk +0 lines, -110 lines 0 comments Download
D content/browser/geofencing/geofencing_service.cc View 1 2 1 chunk +0 lines, -203 lines 0 comments Download
D content/browser/geofencing/geofencing_service_unittest.cc View 1 chunk +0 lines, -198 lines 0 comments Download
D content/browser/geofencing/mock_geofencing_service.h View 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/geofencing/mock_geofencing_service.cc View 1 2 1 chunk +0 lines, -126 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_metrics.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/storage_partition_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/browser/storage_partition_impl.cc View 7 chunks +2 lines, -16 lines 0 comments Download
M content/child/blink_platform_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M content/child/child_thread_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
D content/child/geofencing/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D content/child/geofencing/geofencing_dispatcher.h View 1 chunk +0 lines, -99 lines 0 comments Download
D content/child/geofencing/geofencing_dispatcher.cc View 1 2 1 chunk +0 lines, -228 lines 0 comments Download
D content/child/geofencing/geofencing_message_filter.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/child/geofencing/geofencing_message_filter.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D content/child/geofencing/web_geofencing_provider_impl.h View 1 chunk +0 lines, -56 lines 0 comments Download
D content/child/geofencing/web_geofencing_provider_impl.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M content/common/DEPS View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/geofencing_messages.h View 1 chunk +0 lines, -82 lines 0 comments Download
D content/common/geofencing_types.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/common/geofencing_types.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 4 chunks +0 lines, -13 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/storage_partition.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/test/layouttest_support.h View 1 chunk +0 lines, -11 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 3 chunks +0 lines, -15 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M ipc/ipc_message_start.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/geofencing/event_triggering.html View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/geofencing/resources/emptyworker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/geofencing/resources/worker-passes-events-back.js View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/geofencing/resources/worker-service-not-available.js View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/geofencing/service-not-available.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/geofencing/service-worker.html View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 6 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-createEvent-expected.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 3 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/geofencing/CircularGeofencingRegion.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/CircularGeofencingRegion.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/CircularGeofencingRegion.idl View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/CircularGeofencingRegionInit.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/Geofencing.h View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/Geofencing.cpp View 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/Geofencing.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/GeofencingError.h View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/GeofencingError.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/GeofencingEvent.h View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/GeofencingEvent.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/GeofencingEvent.idl View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/GeofencingRegion.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/GeofencingRegion.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/geofencing/ServiceWorkerGlobalScopeGeofencing.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/ServiceWorkerGlobalScopeGeofencing.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/ServiceWorkerRegistrationGeofencing.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/ServiceWorkerRegistrationGeofencing.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/ServiceWorkerRegistrationGeofencing.idl View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/WorkerNavigatorGeofencing.h View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/WorkerNavigatorGeofencing.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/Source/modules/geofencing/WorkerNavigatorGeofencing.idl View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 6 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 2 chunks +0 lines, -6 lines 0 comments Download
D third_party/WebKit/public/platform/WebCircularGeofencingRegion.h View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/public/platform/WebGeofencingError.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/public/platform/WebGeofencingEventType.h View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/public/platform/WebGeofencingProvider.h View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/public/platform/WebGeofencingRegistration.h View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h View 3 chunks +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Marijn Kruisselbrink
mkwst@ for blink and IPC OWNERS mpearson@ for histograms OWNERS and jam@ for content and ...
4 years, 7 months ago (2016-05-11 22:12:26 UTC) #4
Marijn Kruisselbrink
mkwst@ for blink and IPC OWNERS mpearson@ for histograms OWNERS and jam@ for content and ...
4 years, 7 months ago (2016-05-11 22:12:26 UTC) #5
jam
lgtm
4 years, 7 months ago (2016-05-11 22:21:42 UTC) #6
Mark P
https://codereview.chromium.org/1972733002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1972733002/diff/20001/tools/metrics/histograms/histograms.xml#oldcode94435 tools/metrics/histograms/histograms.xml:94435: - <suffix name="GEOFENCING" label="GEOFENCING"/> Please mark this suffix as ...
4 years, 7 months ago (2016-05-11 22:52:23 UTC) #7
Marijn Kruisselbrink
https://codereview.chromium.org/1972733002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1972733002/diff/20001/tools/metrics/histograms/histograms.xml#oldcode94435 tools/metrics/histograms/histograms.xml:94435: - <suffix name="GEOFENCING" label="GEOFENCING"/> On 2016/05/11 at 22:52:23, Mark ...
4 years, 7 months ago (2016-05-11 23:04:51 UTC) #8
Mark P
histograms.xml lgtm
4 years, 7 months ago (2016-05-11 23:06:28 UTC) #9
haraken
WebKit/Source/ LGTM
4 years, 7 months ago (2016-05-11 23:43:33 UTC) #10
Mike West
LGTM.
4 years, 7 months ago (2016-05-13 15:08:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972733002/40001
4 years, 7 months ago (2016-05-13 15:43:28 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-13 19:06:22 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 19:08:06 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e078907f62cb060ddd19fe3dddea3e2142c0f7d8
Cr-Commit-Position: refs/heads/master@{#393597}

Powered by Google App Engine
This is Rietveld 408576698