Multiple :hover/:active incorrectly matching in quirks mode.

Multiple :hover/:active incorrectly matching in quirks mode.

:hover and :active should only match links when not accompanied by
other simple selectors in quirks mode. We failed to adhere for
combinations of :hover and :active. Instead of just checking there is
either a selector preceding or following in the compound, check if
there is a selector preceding or a selector following in the compound
which is neither :hover nor :active.

R=rob.buis@samsung.com
BUG=611090
Committed: https://crrev.com/8a262d51788ada7f1f9158049d3576c9b1b09b1a
Cr-Commit-Position: refs/heads/master@{#393090}

[rune, 2016-05-11 17:46:49]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 17:47:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972713002/1

[rune, 2016-05-11 18:28:04]

The CQ bit was unchecked by rune@opera.com

[rune, 2016-05-11 18:29:19]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[rune, 2016-05-11 18:29:44]

ptal

[commit-bot: I haz the power, 2016-05-11 18:29:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972713002/20001

[rwlbuis, 2016-05-11 21:30:34]

https://codereview.chromium.org/1972713002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/hover-active-quirks.html (right):

https://codereview.chromium.org/1972713002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/hover-active-quirks.html:57:
<br><span>Should be green when active and not hovered:</span>
When I tried this part manually it did not work as advertised, i.e. clicking
either div (I assume that is the only way to make it active) it did not turn
green. Can you check?

[rune, 2016-05-11 21:44:17]

https://codereview.chromium.org/1972713002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/hover-active-quirks.html (right):

https://codereview.chromium.org/1972713002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/hover-active-quirks.html:57:
<br><span>Should be green when active and not hovered:</span>
On 2016/05/11 21:30:34, rwlbuis wrote:
> When I tried this part manually it did not work as advertised, i.e. clicking
> either div (I assume that is the only way to make it active) it did not turn
> green. Can you check?

They will turn green when active and no longer hovered. That is:

1. Hover the block
2. Mouse button down
3. While mouse button down, move the pointer away from the block => green.

[rwlbuis, 2016-05-11 21:55:19]

On 2016/05/11 21:44:17, rune wrote:
>
https://codereview.chromium.org/1972713002/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/fast/css/hover-active-quirks.html (right):
> 
>
https://codereview.chromium.org/1972713002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/css/hover-active-quirks.html:57:
> <br><span>Should be green when active and not hovered:</span>
> On 2016/05/11 21:30:34, rwlbuis wrote:
> > When I tried this part manually it did not work as advertised, i.e. clicking
> > either div (I assume that is the only way to make it active) it did not turn
> > green. Can you check?
> 
> They will turn green when active and no longer hovered. That is:
> 
> 1. Hover the block
> 2. Mouse button down
> 3. While mouse button down, move the pointer away from the block => green.

Ah, that does the trick! LGTM.

[commit-bot: I haz the power, 2016-05-11 22:31:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 22:31:02]

Dry run: This issue passed the CQ dry run.

[rune, 2016-05-11 22:31:48]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-05-11 22:32:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972713002/20001

[commit-bot: I haz the power, 2016-05-11 22:39:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-11 22:41:41]

Description was changed from

==========
Multiple :hover/:active incorrectly matching in quirks mode.

:hover and :active should only match links when not accompanied by
other simple selectors in quirks mode. We failed to adhere for
combinations of :hover and :active. Instead of just checking there is
either a selector preceding or following in the compound, check if
there is a selector preceding or a selector following in the compound
which is neither :hover nor :active.

R=rob.buis@samsung.com
BUG=611090
==========

to

==========
Multiple :hover/:active incorrectly matching in quirks mode.

:hover and :active should only match links when not accompanied by
other simple selectors in quirks mode. We failed to adhere for
combinations of :hover and :active. Instead of just checking there is
either a selector preceding or following in the compound, check if
there is a selector preceding or a selector following in the compound
which is neither :hover nor :active.

R=rob.buis@samsung.com
BUG=611090

Committed: https://crrev.com/8a262d51788ada7f1f9158049d3576c9b1b09b1a
Cr-Commit-Position: refs/heads/master@{#393090}
==========

[commit-bot: I haz the power, 2016-05-11 22:41:42]

Patchset 2 (id:??) landed as
https://crrev.com/8a262d51788ada7f1f9158049d3576c9b1b09b1a
Cr-Commit-Position: refs/heads/master@{#393090}