third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp - Issue 1972683002: Early reporting of opaqueness by decoders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

Issue 1972683002: Early reporting of opaqueness by decoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h » ('j') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

index 9a0d7dc5a67480e39e8406169387b2a65c6c8ce1..604d867f155ef37680028c0f08e0aa57f2dc9dea 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

@@ -152,12 +152,16 @@ TEST(GIFImageDecoderTest, parseAndDecode)

EXPECT_EQ(ImageFrame::FrameComplete, frame->getStatus());

EXPECT_EQ(16, frame->getSkBitmap().width());

EXPECT_EQ(16, frame->getSkBitmap().height());

+ EXPECT_FALSE(decoder->frameHasAlphaAtIndex(0));

+ EXPECT_FALSE(decoder->frameHasAlphaAtIndex(1));

frame = decoder->frameBufferAtIndex(1);

EXPECT_EQ(ImageFrame::FrameComplete, frame->getStatus());

EXPECT_EQ(16, frame->getSkBitmap().width());

EXPECT_EQ(16, frame->getSkBitmap().height());

EXPECT_EQ(cAnimationLoopInfinite, decoder->repetitionCount());

+ EXPECT_FALSE(decoder->frameHasAlphaAtIndex(0));

+ EXPECT_FALSE(decoder->frameHasAlphaAtIndex(1));

}

TEST(GIFImageDecoderTest, parseByteByByte)

@@ -328,11 +332,17 @@ TEST(GIFImageDecoderTest, frameIsCompleteLoading)

EXPECT_FALSE(decoder->failed());

EXPECT_TRUE(decoder->frameIsCompleteAtIndex(0));

EXPECT_FALSE(decoder->frameIsCompleteAtIndex(1));

+ EXPECT_FALSE(decoder->frameHasAlphaAtIndex(0));

+ EXPECT_TRUE(decoder->frameHasAlphaAtIndex(1));

+ EXPECT_TRUE(decoder->frameHasAlphaAtIndex(2));

decoder->setData(data.get(), true);

EXPECT_EQ(2u, decoder->frameCount());

EXPECT_TRUE(decoder->frameIsCompleteAtIndex(0));

EXPECT_TRUE(decoder->frameIsCompleteAtIndex(1));

+ EXPECT_FALSE(decoder->frameHasAlphaAtIndex(0));

+ EXPECT_FALSE(decoder->frameHasAlphaAtIndex(1));

+ EXPECT_TRUE(decoder->frameHasAlphaAtIndex(2));

}

TEST(GIFImageDecoderTest, badTerminator)