Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1972613002: Support subclassing API functions (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support subclassing API functions. When instantiating a subclassed API function, the instance cache is avoided. There is currently no direct API yet to instantiate a Template while passing in a new.target. It probably makes sense to extend ObjectTemplate::NewInstance to accept a new.target, in line with Reflect.construct. BUG=v8:3330, v8:5001 Committed: https://crrev.com/73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0 Cr-Commit-Position: refs/heads/master@{#36179}

Patch Set 1 #

Patch Set 2 : Simplify #

Patch Set 3 : #

Patch Set 4 : Add test for Reflect.construct with base-class new-target #

Patch Set 5 : Modify test to actually test Reflect.construct #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -58 lines) Patch
M src/api-natives.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/api-natives.cc View 1 2 3 4 5 6 chunks +39 lines, -18 lines 0 comments Download
M src/builtins.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +32 lines, -30 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 2 chunks +89 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Toon Verwaest
ptal
4 years, 7 months ago (2016-05-11 13:04:56 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-05-11 13:43:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972613002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972613002/100001
4 years, 7 months ago (2016-05-11 13:50:54 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-11 14:21:38 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 14:22:46 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/73ee79438c26d8e1cfd18cdd6c6de3ef4ecf9db0
Cr-Commit-Position: refs/heads/master@{#36179}

Powered by Google App Engine
This is Rietveld 408576698