Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 19726012: all in the gyp (Closed)

Created:
7 years, 5 months ago by mtklein
Modified:
7 years, 5 months ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : no quotes #

Patch Set 3 : forgot this #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 1 2 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
Waiting on the power issues to be sure, but local testing indicates this'll be okay.
7 years, 5 months ago (2013-07-24 15:42:34 UTC) #1
caryclark
On 2013/07/24 15:42:34, mtklein wrote: > Waiting on the power issues to be sure, but ...
7 years, 5 months ago (2013-07-24 15:45:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/19726012/1005
7 years, 5 months ago (2013-07-24 15:48:54 UTC) #3
mtklein
7 years, 5 months ago (2013-07-24 16:20:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r10315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698