[wasm] Add flag to validate asm.js modules.

[wasm] Add flag to validate asm.js modules.

This adds the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, a warning will be printed, but compilation as well as
execution will continue unhampered.

R=mvstanton@chromium.org

Committed: https://crrev.com/f73cf983c081130c4f8b5d214133f1eebc67f7d3
Cr-Commit-Position: refs/heads/master@{#36216}

[Michael Starzinger, 2016-05-11 11:51:22]

Description was changed from

==========
[wasm] Add flag to validate asm.js modules.

This add the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, an error will be thrown to abort execution.

R=mvstanton@chromium.org
==========

to

==========
[wasm] Add flag to validate asm.js modules.

This adds the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, an error will be printed, but compilation as well as
execution will continue unhampered.

R=mvstanton@chromium.org
==========

[Michael Starzinger, 2016-05-11 11:53:02]

Description was changed from

==========
[wasm] Add flag to validate asm.js modules.

This adds the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, an error will be printed, but compilation as well as
execution will continue unhampered.

R=mvstanton@chromium.org
==========

to

==========
[wasm] Add flag to validate asm.js modules.

This adds the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, a warning will be printed, but compilation as well as
execution will continue unhampered.

R=mvstanton@chromium.org
==========

[bradnelson, 2016-05-12 09:03:58]

bradnelson@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bradnelson, 2016-05-12 09:03:59]

Thanks guys, sorry this has been held up so long.
Let's chat about this more tomorrow.

https://codereview.chromium.org/1972593002/diff/20001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1972593002/diff/20001/src/compiler.cc#newcode467
src/compiler.cc:467: EnsureFeedbackVector(info);
I've been thrashing about a bit attempting to craft a similar CL.
I'd vacillated if this was a good place to glue things in, thanks. :-)

One issue with this spot (and several others), is that the AST is lazy here
(doesn't have child function bodies).
The typer currently requires this, which of course won't do in terms of memory
footprint.

My intention is to have it selectively parse these, but wasn't sure if that
belongs in the typer, or external to it, curious what you guys think?

As near as I can tell, assuming I don't keep the full AST in memory, two parses
/ passes through each function will be required which is a shame. The first is
needed to gather up function signatures (which touches very little of the AST),
the second to actually type the function (which could also be done in tandem
with asm->wasm for the function).

https://codereview.chromium.org/1972593002/diff/20001/src/compiler.cc#newcode475
src/compiler.cc:475: DCHECK(!info->isolate()->has_pending_exception());
My intention was that in the failure case the TypingResetter gets run on the
AST, as the asm typer leaves behind partial type info (that can be wrong in the
failure case). Also some of the backends (crankshaft anyway) don't like having
types set.
Or maybe reseting the AST types should get called/folded into AsmTyper?

In any event, I plan to swap out using types.h types on the AST for something
outside the AST real soon, so likely moot.

[mvstanton, 2016-05-12 09:16:50]

lgtm

[bradnelson, 2016-05-12 15:52:00]

The CQ bit was checked by bradnelson@chromium.org

[commit-bot: I haz the power, 2016-05-12 15:52:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972593002/20001

[commit-bot: I haz the power, 2016-05-12 16:35:57]

Description was changed from

==========
[wasm] Add flag to validate asm.js modules.

This adds the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, a warning will be printed, but compilation as well as
execution will continue unhampered.

R=mvstanton@chromium.org
==========

to

==========
[wasm] Add flag to validate asm.js modules.

This adds the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, a warning will be printed, but compilation as well as
execution will continue unhampered.

R=mvstanton@chromium.org
==========

[commit-bot: I haz the power, 2016-05-12 16:35:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-12 16:36:33]

Description was changed from

==========
[wasm] Add flag to validate asm.js modules.

This adds the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, a warning will be printed, but compilation as well as
execution will continue unhampered.

R=mvstanton@chromium.org
==========

to

==========
[wasm] Add flag to validate asm.js modules.

This adds the --validate-asm flag which will trigger validation of all
asm.js modules before they are being compiled. In case a module doesn't
pass validation, a warning will be printed, but compilation as well as
execution will continue unhampered.

R=mvstanton@chromium.org

Committed: https://crrev.com/f73cf983c081130c4f8b5d214133f1eebc67f7d3
Cr-Commit-Position: refs/heads/master@{#36216}
==========

[commit-bot: I haz the power, 2016-05-12 16:36:34]

Patchset 2 (id:??) landed as
https://crrev.com/f73cf983c081130c4f8b5d214133f1eebc67f7d3
Cr-Commit-Position: refs/heads/master@{#36216}