Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1972563002: [turbofan] Infer some receiver maps when lowering loads/stores. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Infer some receiver maps when lowering loads/stores. The type feedback for load and store ICs might be polluted because of different/conflicting call sites, but yet we can utilize some of the static information that is available in the graph to determine the effective receiver map, or at least filter out impossible receiver maps from the feedback by looking at the transition trees. This is similar to what Crankshaft does in ComputeReceiverTypes, but more general and less hacky. R=jarin@chromium.org Committed: https://crrev.com/9c5d12e5fb3d489cafba69e8962613847479c731 Cr-Commit-Position: refs/heads/master@{#36167}

Patch Set 1 #

Patch Set 2 : Make tests happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -5 lines) Patch
M src/compiler/js-native-context-specialization.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 6 chunks +111 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-11 09:43:10 UTC) #1
Benedikt Meurer
Hey Jaro, Here's an initial shot to improve RayTrace and some other benchmarks. Please take ...
4 years, 7 months ago (2016-05-11 09:44:45 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-11 09:58:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972563002/1
4 years, 7 months ago (2016-05-11 09:59:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/1455) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-11 10:11:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972563002/20001
4 years, 7 months ago (2016-05-11 10:45:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-11 11:14:35 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 11:15:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c5d12e5fb3d489cafba69e8962613847479c731
Cr-Commit-Position: refs/heads/master@{#36167}

Powered by Google App Engine
This is Rietveld 408576698