Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1972543003:
Delete last remaining CLD deps. (Closed)
|
Created:
4 years, 7 months ago by Andrew Hayden (chromium.org) Modified:
4 years, 7 months ago CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDelete last remaining CLD deps.
This is being split from the following review in order to get through
the bots safely without breaking the tree:
https://codereview.chromium.org/1917903004/
We will delete the DEPS to ensure no build-time dependencies at all on
CLD, then break/delete the problematic
compact_lang_det_generated_quadschrome.cc file that is causing bots to
have issues with the larger patchset.
TBR as this is already reviewed at the link above.
BUG=605688
Committed: https://crrev.com/865388d35da3f286d7caa9de61f0b297a382ddb3
Cr-Commit-Position: refs/heads/master@{#394417}
Patch Set 1 #
Messages
Total messages: 24 (11 generated)
Description was changed from ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 NOTRY=true TBR=toyoshim@chromium.org ========== to ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 NOTRY=true TBR=toyoshim@chromium.org ==========
andrewhayden@chromium.org changed reviewers: + thakis@chromium.org
Why NOTRY=true? Let me kick CQ dry run to check unexpected build issues.
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972543003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ah, that could be because of crbug.com/606795? Anyway, running CQ would help to confirm other issues do not exist. LGTM if bot results are what we expect.
Description was changed from ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 NOTRY=true TBR=toyoshim@chromium.org ========== to ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 NOTRY=true ==========
I removed TBR line since I already looked.
Description was changed from ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 NOTRY=true ========== to ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 ==========
The CQ bit was checked by andrewhayden@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972543003/1
I had set notry because we've already run this in the related CL, and we know it should be ok. But I've removed notry now.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Nico, still need an ell-gee-tee-em from you on the tracer.
lgtm
The CQ bit was checked by andrewhayden@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972543003/1
Message was sent while issue was closed.
Description was changed from ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 ========== to ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 ========== to ========== Delete last remaining CLD deps. This is being split from the following review in order to get through the bots safely without breaking the tree: https://codereview.chromium.org/1917903004/ We will delete the DEPS to ensure no build-time dependencies at all on CLD, then break/delete the problematic compact_lang_det_generated_quadschrome.cc file that is causing bots to have issues with the larger patchset. TBR as this is already reviewed at the link above. BUG=605688 Committed: https://crrev.com/865388d35da3f286d7caa9de61f0b297a382ddb3 Cr-Commit-Position: refs/heads/master@{#394417} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/865388d35da3f286d7caa9de61f0b297a382ddb3 Cr-Commit-Position: refs/heads/master@{#394417} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
