Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1972523003: Improve Observatory Timeline UI (Closed)

Created:
4 years, 7 months ago by Cutch
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve Observatory Timeline UI - [x] Remove Stop / Start buttons and replace with fine grained category control. - [x] Restrict the cpu profile to the time span of the timeline. - [x] Display recorder name. - [x] Show a popup when fetching the timeline from the VM. - [x] Show a popup when fetching the cpu profile(s) from the VM. Fixes #26401 Fixes #26394 BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/db07faaa8c6327555f65ef668fccc5c305233e7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -89 lines) Patch
M runtime/observatory/lib/src/elements/timeline_page.dart View 4 chunks +72 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/elements/timeline_page.html View 1 chunk +15 lines, -5 lines 0 comments Download
M runtime/observatory/web/timeline.html View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/web/timeline.js View 8 chunks +67 lines, -61 lines 0 comments Download
A runtime/observatory/web/timeline_message_handler.js View 1 chunk +49 lines, -0 lines 0 comments Download
M runtime/vm/timeline.h View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/timeline.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 7 months ago (2016-05-11 23:59:21 UTC) #3
rmacnak
lgtm
4 years, 7 months ago (2016-05-12 04:21:22 UTC) #4
Cutch
4 years, 7 months ago (2016-05-12 14:16:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db07faaa8c6327555f65ef668fccc5c305233e7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698