Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp

Issue 1972503002: Add flag "distillability-dev" for distillability development Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
diff --git a/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp b/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
index 24fa4b3dd6eae528feee07b9e7c0448c10749cbd..b13a47690d0612de46c3bd2ecbd422de32adc94e 100644
--- a/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
+++ b/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
@@ -13,6 +13,7 @@
#include "core/html/HTMLHeadElement.h"
#include "core/html/HTMLInputElement.h"
#include "core/html/HTMLMetaElement.h"
+#include "core/inspector/ConsoleMessage.h"
#include "platform/Histogram.h"
#include "public/platform/Platform.h"
#include "public/platform/WebDistillability.h"
@@ -213,7 +214,7 @@ bool isMobileFriendly(Document& document)
} // namespace
-WebDistillabilityFeatures DocumentStatisticsCollector::collectStatistics(Document& document)
+WebDistillabilityFeatures DocumentStatisticsCollector::collectStatistics(Document& document, bool dumpInfo)
{
TRACE_EVENT0("blink", "DocumentStatisticsCollector::collectStatistics");
@@ -246,6 +247,33 @@ WebDistillabilityFeatures DocumentStatisticsCollector::collectStatistics(Documen
DEFINE_STATIC_LOCAL(CustomCountHistogram, distillabilityHistogram, ("WebCore.DistillabilityUs", 1, 1000000, 50));
distillabilityHistogram.count(static_cast<int>(1e6 * elapsedTime));
+ if (dumpInfo) {
+ StringBuilder message;
+ message.append("distillability_features = {\"isMobileFriendly\": ");
+ message.appendNumber(features.isMobileFriendly);
+ message.append(", \"openGraph\": ");
+ message.appendNumber(features.openGraph);
+ message.append(", \"elementCount\": ");
+ message.appendNumber(features.elementCount);
+ message.append(", \"anchorCount\": ");
+ message.appendNumber(features.anchorCount);
+ message.append(", \"formCount\": ");
+ message.appendNumber(features.formCount);
+ message.append(", \"textInputCount\": ");
+ message.appendNumber(features.textInputCount);
+ message.append(", \"passwordInputCount\": ");
+ message.appendNumber(features.passwordInputCount);
+ message.append(", \"mozScore\": ");
+ message.appendNumber(features.mozScore);
+ message.append(", \"mozScoreAllSqrt\": ");
+ message.appendNumber(features.mozScoreAllSqrt);
+ message.append(", \"mozScoreAllLinear\": ");
+ message.appendNumber(features.mozScoreAllLinear);
+ message.append("}");
+ ConsoleMessage* consoleMessage = ConsoleMessage::create(ConsoleAPIMessageSource, DebugMessageLevel, message.toString());
mdjones 2016/05/18 19:06:59 Is this automatically cleaned up (does ConsoleMess
wychen 2016/05/18 19:19:01 ConsoleMessage is derived from GarbageCollectedFin
+ document.addConsoleMessage(consoleMessage);
+ }
+
return features;
}

Powered by Google App Engine
This is Rietveld 408576698