Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: gpu/command_buffer/service/sync_point_manager.cc

Issue 1972443002: Insert CHECK to look for abnormal flushes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use CHECK instead Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/sync_point_manager.cc
diff --git a/gpu/command_buffer/service/sync_point_manager.cc b/gpu/command_buffer/service/sync_point_manager.cc
index 9669bb677ab07688bf3f9cf0738500ac403b0207..80d232a3774953690478b149b83ab47bdf79c73a 100644
--- a/gpu/command_buffer/service/sync_point_manager.cc
+++ b/gpu/command_buffer/service/sync_point_manager.cc
@@ -255,6 +255,10 @@ void SyncPointClientState::ReleaseFenceSyncLocked(
fence_sync_lock_.AssertAcquired();
DCHECK_GT(release, fence_sync_release_);
+ // TODO(dyen): https://www.crbug.com/606112 - Hack in a DCHECK which should be
+ // fine under normal circumstances. Under normal usage, this would only
+ // trigger if flushes are arriving out of order.
+ CHECK(release == fence_sync_release_ + 1 || release == UINT64_MAX);
fence_sync_release_ = release;
while (!release_callback_queue_.empty() &&
release_callback_queue_.top().release_count <= release) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698