Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chromecast/browser/cast_content_browser_client.cc

Issue 1972433002: [Chromecast] Handle device scale factor correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simpler approach after offline discussion with alokp Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_content_browser_client.cc
diff --git a/chromecast/browser/cast_content_browser_client.cc b/chromecast/browser/cast_content_browser_client.cc
index 39ffe59e106972dfaeda5bba64eb4660ccaef65a..fafc3729aa7a62b016b18bf8feb773cf67078400 100644
--- a/chromecast/browser/cast_content_browser_client.cc
+++ b/chromecast/browser/cast_content_browser_client.cc
@@ -276,13 +276,18 @@ void CastContentBrowserClient::OverrideWebkitPrefs(
// Enable 5% margins for WebVTT cues to keep within title-safe area
prefs->text_track_margin_percentage = 5;
-#if defined(OS_ANDROID)
+#if !defined(OS_ANDROID)
alokp 2016/05/11 21:48:47 You might want to just set viewport_enabled and vi
+ // Viewport is only enabled by default on Android; we use it consistently
+ // across all platforms.
+ prefs->viewport_enabled = true;
+ prefs->viewport_meta_enabled = true;
+#endif
+
// Enable the television style for viewport so that all cast apps have a
// 1280px wide layout viewport by default.
DCHECK(prefs->viewport_enabled);
DCHECK(prefs->viewport_meta_enabled);
prefs->viewport_style = content::ViewportStyle::TELEVISION;
-#endif // defined(OS_ANDROID)
}
void CastContentBrowserClient::ResourceDispatcherHostCreated() {

Powered by Google App Engine
This is Rietveld 408576698