Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: chromecast/media/base/video_plane_controller.h

Issue 1972433002: [Chromecast] Handle device scale factor correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test compile error Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/graphics/cast_screen.cc ('k') | chromecast/media/base/video_plane_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/media/base/video_plane_controller.h
diff --git a/chromecast/media/base/video_plane_controller.h b/chromecast/media/base/video_plane_controller.h
index 04e9b9431d85d9d33a69eb10f7fff68930cf1234..3d08d14a615c919dbd35b298ef8230ba814390ac 100644
--- a/chromecast/media/base/video_plane_controller.h
+++ b/chromecast/media/base/video_plane_controller.h
@@ -32,7 +32,8 @@ namespace media {
// constructed on.
class VideoPlaneController {
public:
- explicit VideoPlaneController(
+ VideoPlaneController(
+ const Size& graphics_resolution,
scoped_refptr<base::SingleThreadTaskRunner> media_task_runner);
~VideoPlaneController();
// Sets the video plane geometry in *graphics plane coordinates*. If there is
@@ -46,13 +47,6 @@ class VideoPlaneController {
// from the last call to this method, it is a no-op.
void SetScreenResolution(const Size& resolution);
- // Sets graphics hardware plane resolution, and clears any cached video plane
- // geometry parameters. This must be called at least once when the hardware
- // graphics plane resolution (same resolution as display::Screen) is known,
- // then later when it changes. If there is no change to the graphics plane
- // resolution from the last call to this method, it is a no-op.
- void SetGraphicsPlaneResolution(const Size& resolution);
-
// After Pause is called, no further calls to VideoPlane::SetGeometry will be
// made except for any pending calls already scheduled on the media thread.
// The Set methods will however update cached parameters that will take
@@ -84,9 +78,8 @@ class VideoPlaneController {
// Current resolutions
bool have_screen_res_;
- bool have_graphics_plane_res_;
Size screen_res_;
- Size graphics_plane_res_;
+ const Size graphics_plane_res_;
// Saved video plane parameters (in graphics plane coordinates)
// for use when screen resolution changes.
« no previous file with comments | « chromecast/graphics/cast_screen.cc ('k') | chromecast/media/base/video_plane_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698