base: add MockTimer

base/timer/mock_timer.h

Index: base/timer/mock_timer.h
diff --git a/base/timer/mock_timer.h b/base/timer/mock_timer.h
new file mode 100644
index 0000000000000000000000000000000000000000..74c11a7d0f40e85f718bedf6a8072f7667f34df6
--- /dev/null
+++ b/base/timer/mock_timer.h
@@ -0,0 +1,42 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TIMER_MOCK_TIMER_H_
+#define BASE_TIMER_MOCK_TIMER_H_
+
+#include "base/timer/timer.h"
+
+namespace base {
+
+class BASE_EXPORT MockTimer : public Timer {
+ public:
+  MockTimer(bool retain_user_task, bool is_repeating);
+  MockTimer(const tracked_objects::Location& posted_from,
+            TimeDelta delay,
+            const base::Closure& user_task,
+            bool is_repeating);
+  virtual ~MockTimer();
+
+  // base::Timer implementation.
+  virtual bool IsRunning() const OVERRIDE;
+  virtual base::TimeDelta GetCurrentDelay() const OVERRIDE;
+  virtual void Start(const tracked_objects::Location& posted_from,
+                     base::TimeDelta delay,
+                     const base::Closure& user_task) OVERRIDE;
+  virtual void Stop() OVERRIDE;
+  virtual void Reset() OVERRIDE;
+
+  // Testing methods.
+  virtual void Fire();

[Mark Mentovai, 2014/03/13 15:17:34]

Doesn’t need to be virtual.

[Elly Fong-Jones, 2014/03/13 15:30:09]

Done.

+ protected:

[Mark Mentovai, 2014/03/13 15:17:34]

This should be private, not protected. Also, a nit: put a blank line before it
to set it off from the Fire method above.

[Elly Fong-Jones, 2014/03/13 15:30:09]

Done.

+  base::Closure user_task_;

[Mark Mentovai, 2014/03/13 15:17:34]

All of these fields duplicate fields in the base class. Is the duplication
really needed? Can most or all of it be avoided by accessing the fields of the
base?

You may need to add accessors to the base to make this work. My rule of thumb
would be to add accessors for anything that you can, but not to add any mutators
to the base class just to make this test class work.

[Elly Fong-Jones, 2014/03/13 15:30:09]

Okay. I moved retain_user_task_ and is_repeating_ into the parent class and
added accessors, but I can't move delay_, is_running_ or user_task_ because I'd
need to add test-only accessors for them.

+  bool retain_user_task_;
+  TimeDelta delay_;
+  bool is_repeating_;
+  bool is_running_;
+};
+
+}  // namespace base
+
+#endif  // !BASE_TIMER_MOCK_TIMER_H_