Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1972403002:
Parse parametric gamma curves (Closed)
DescriptionParse parametric gamma curves
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1972403002
Committed: https://skia.googlesource.com/skia/+/61a999ca3e2c865a121a6eb378ff85a837b87a44
Patch Set 1 #Patch Set 2 : Rebase #
Total comments: 2
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Parse parametric gamma curves BUG=skia: ========== to ========== Parse parametric gamma curves BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
msarett@google.com changed reviewers: + scroggo@google.com
reed@google.com changed reviewers: + reed@google.com
lets consider moving all of the gamma types into a priv header, in preparation for making this guy public. May mean having a ptr to the Gammas, but that is probably ok.
On 2016/05/13 19:08:07, reed1 wrote: > lets consider moving all of the gamma types into a priv header, in preparation > for making this guy public. May mean having a ptr to the Gammas, but that is > probably ok. Ok, I think I'll do that in a separate CL and then come back to this.
Patchset #3 (id:40001) has been deleted
Patchset #3 (id:60001) has been deleted
Patchset #2 (id:20001) has been deleted
I've rebased this on the recent changes to SkColorSpace. I think this is the last addition to the SkGammas struct. I'll probably try to streamline it in follow-ups. Mike had a few good ideas: (1) Take advantage of the fact that the SkGammaCurves are almost always identical. (2) Take advantage of the fact that we only ever have a value OR a table OR parameters. (3) Contain all of the necessary info in a single malloc.
lgtm https://codereview.chromium.org/1972403002/diff/80001/src/core/SkColorSpacePr... File src/core/SkColorSpacePriv.h (right): https://codereview.chromium.org/1972403002/diff/80001/src/core/SkColorSpacePr... src/core/SkColorSpacePriv.h:45: float fG; Why does G come first?
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972403002/80001
https://codereview.chromium.org/1972403002/diff/80001/src/core/SkColorSpacePr... File src/core/SkColorSpacePriv.h (right): https://codereview.chromium.org/1972403002/diff/80001/src/core/SkColorSpacePr... src/core/SkColorSpacePriv.h:45: float fG; On 2016/05/18 12:49:15, scroggo wrote: > Why does G come first? In my mind it makes sense because g is the "most important". Every parametric curve always has an exponent g. And g is always the first parameter that we read from the profile. We check whether or not we have g to decide if we actually have a parametric curve. The other parameters are optional (except I guess we always have A as well...)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1972403002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1972403002/80001
Message was sent while issue was closed.
Description was changed from ========== Parse parametric gamma curves BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Parse parametric gamma curves BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/61a999ca3e2c865a121a6eb378ff85a837b87a44 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as https://skia.googlesource.com/skia/+/61a999ca3e2c865a121a6eb378ff85a837b87a44 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
