DescriptionLogger: introduce abstract interface for CodeEvent listeners.
New abstract class CodeEventListener was created.
CodeEventLogger which is the base class for Jit, LowLevel
and CodeAddressMap loggers was inherited from CodeEventListener.
CodeAddressMap class was moved to serializer.cc because serializer is the only user for it. Actually it collects code names and pushes them to the standard log as SnapshotCodeNameEvent. So I extracted this code into separate function CodeNameEvent. It happens that this method works only when Serializer serializes an object. So I added direct log call there.
CodeEventLogger class declaration was moved to the header
because CodeAddressMap needs it.
The code for the nested class CodeEventLogger::NameBuffer was left in the cc file.
CpuProfiler now is inherit CodeEventListener but not used
the loggers infrastructure yet due to the complex initialization schema. I'd like to fix that in a separate cl.
BUG=none
TEST=current test set.
R=yangguo@chromium.org, yurys@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=15911
Patch Set 1 #
Total comments: 2
Patch Set 2 : comments addressed #
Total comments: 1
Patch Set 3 : comments addressed #
Total comments: 3
Patch Set 4 : comments addressed #
Total comments: 1
Patch Set 5 : comments addressed. rebaselined. #
Messages
Total messages: 13 (0 generated)
|