chrome/browser/resources/translate_internals/translate_internals.html - Issue 19724006: Use URL hashes to switch tabs of chrome://translate-internals/

Side by Side Diff: chrome/browser/resources/translate_internals/translate_internals.html

Issue 19724006: Use URL hashes to switch tabs of chrome://translate-internals/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/translate_internals/translate_internals.css ('k') | chrome/browser/resources/translate_internals/translate_internals.js » ('j') | chrome/browser/resources/translate_internals/translate_internals.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <html i18n-values="dir:textdirection">	2 <html i18n-values="dir:textdirection">

3 <!--	3 <!--

4 Copyright 2013 The Chromium Authors. All rights reserved.	4 Copyright 2013 The Chromium Authors. All rights reserved.

5 Use of this source code is governed by a BSD-style license that can be	5 Use of this source code is governed by a BSD-style license that can be

6 found in the LICENSE file.	6 found in the LICENSE file.

7 -->	7 -->

8 <head>	8 <head>

9 <meta charset="utf-8">	9 <meta charset="utf-8">

10 <title>Translate Internals</title>	10 <title>Translate Internals</title>

(...skipping 14 matching lines...) Expand all Loading...
25	25

26 <tabbox>	26 <tabbox>

27 <tabs>	27 <tabs>

28 <tab>Prefs</tab>	28 <tab>Prefs</tab>

29 <tab>Detection Logs</tab>	29 <tab>Detection Logs</tab>

30 <tab>Error Logs</tab>	30 <tab>Error Logs</tab>

31 <tab>Event Logs</tab>	31 <tab>Event Logs</tab>

32 </tabs>	32 </tabs>

33 <tabpanels>	33 <tabpanels>

34	34

35 <tabpanel id="prefs">	35 <tabpanel id="tabpanel-prefs">
	Evan Stade 2013/07/22 19:06:04 why did you change this? seems like it just makes why did you change this? seems like it just makes calculating the hash a little harder. hajimehoshi 2013/07/23 03:56:19 The reason why I changed the ID is because I wante The reason why I changed the ID is because I wanted to use #prefs to navigate the tab, but #prefs conflicted the behavior of Chrome to jump the 'position' of the tabpanel element. On 2013/07/22 19:06:04, Evan Stade wrote: Show quoted text > why did you change this? seems like it just makes calculating the hash a little > harder.
36 <div>	36 <div>

37 <include src="prefs.html"/>	37 <include src="prefs.html"/>

38 </div>	38 </div>

39 </tabpanel>	39 </tabpanel>

40	40

41 <tabpanel id="detection-logs">	41 <tabpanel id="tabpanel-detection-logs">

42 <div>	42 <div>

43 <include src="detection_logs.html"/>	43 <include src="detection_logs.html"/>

44 </div>	44 </div>

45 </tabpanel>	45 </tabpanel>

46	46

47 <tabpanel id="error-logs">	47 <tabpanel id="tabpanel-error-logs">

48 <div>	48 <div>

49 <include src="error_logs.html"/>	49 <include src="error_logs.html"/>

50 </div>	50 </div>

51 </tabpanel>	51 </tabpanel>

52	52

53 <tabpanel id="event-logs">	53 <tabpanel id="tabpanel-event-logs">

54 <div>	54 <div>

55 <include src="event_logs.html"/>	55 <include src="event_logs.html"/>

56 </div>	56 </div>

57 </tabpanel>	57 </tabpanel>

58	58

59 </tabpanels>	59 </tabpanels>

60 </tabbox>	60 </tabbox>

61	61

62 <script src="chrome://resources/js/i18n_template.js"></script>	62 <script src="chrome://resources/js/i18n_template.js"></script>

63 <script src="chrome://resources/js/i18n_process.js"></script>	63 <script src="chrome://resources/js/i18n_process.js"></script>

64 <script src="chrome://resources/js/jstemplate_compiled.js"></script>	64 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

65 </body>	65 </body>

66	66

67 </html>	67 </html>

OLD	NEW