Implement the notifyCharacteristicValueChanged API.

Implement the notifyCharacteristicValueChanged API.

This CL adds the implementation and tests for the
notifyGetCharacteristicValueChanged API.

R=xiyuan@chromium.org
BUG=610393
Committed: https://crrev.com/eac4477142e8b6671468891d40fa9f2c2d83cd68
Cr-Commit-Position: refs/heads/master@{#393628}

[rkc, 2016-05-12 23:05:07]

The CQ bit was checked by rkc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 23:05:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972353002/1

[commit-bot: I haz the power, 2016-05-12 23:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 23:45:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2016-05-13 16:07:57]

lgtm

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
File
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed/runtest.js
(right):

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed/runtest.js:21:

nit: remove?

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed/runtest.js:38:
var newValue = new ArrayBuffer(bytes.length);
|newValue| is an 6 byte buffer filled with 0.

Should we do this instead?

var newValue = (new Uint8Array(bytes)).buffer;

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
File
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed_error_conditions/runtest.js
(right):

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed_error_conditions/runtest.js:21:

nit: nuke one empty line?

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed_error_conditions/runtest.js:41:
var newValue = new ArrayBuffer(bytes.length);
nit: fill |newValue| with real bytes as aforementioned?

[rkc, 2016-05-13 19:00:18]

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
File
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed/runtest.js
(right):

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed/runtest.js:21:

On 2016/05/13 16:07:57, xiyuan wrote:
> nit: remove?

Done.

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed/runtest.js:38:
var newValue = new ArrayBuffer(bytes.length);
On 2016/05/13 16:07:57, xiyuan wrote:
> |newValue| is an 6 byte buffer filled with 0.
> 
> Should we do this instead?
> 
> var newValue = (new Uint8Array(bytes)).buffer;

Done.

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
File
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed_error_conditions/runtest.js
(right):

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed_error_conditions/runtest.js:21:

On 2016/05/13 16:07:57, xiyuan wrote:
> nit: nuke one empty line?

Done.

https://codereview.chromium.org/1972353002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/bluetooth_low_energy/notify_characteristic_value_changed_error_conditions/runtest.js:41:
var newValue = new ArrayBuffer(bytes.length);
On 2016/05/13 16:07:57, xiyuan wrote:
> nit: fill |newValue| with real bytes as aforementioned?

Done.

[rkc, 2016-05-13 19:00:25]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-05-13 19:00:28]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1972353002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-13 19:00:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972353002/20001

[commit-bot: I haz the power, 2016-05-13 20:44:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-13 20:46:26]

Description was changed from

==========
Implement the notifyCharacteristicValueChanged API.

This CL adds the implementation and tests for the
notifyGetCharacteristicValueChanged API.

R=xiyuan@chromium.org
BUG=610393
==========

to

==========
Implement the notifyCharacteristicValueChanged API.

This CL adds the implementation and tests for the
notifyGetCharacteristicValueChanged API.

R=xiyuan@chromium.org
BUG=610393

Committed: https://crrev.com/eac4477142e8b6671468891d40fa9f2c2d83cd68
Cr-Commit-Position: refs/heads/master@{#393628}
==========

[commit-bot: I haz the power, 2016-05-13 20:46:27]

Patchset 2 (id:??) landed as
https://crrev.com/eac4477142e8b6671468891d40fa9f2c2d83cd68
Cr-Commit-Position: refs/heads/master@{#393628}