Issue 197233011: Add a utility method to the ia32 macro assembler to move a double immediate into an XMM register.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197233011: Add a utility method to the ia32 macro assembler to move a double immediate into an XMM register. (Closed)

Created:
6 years, 9 months ago by titzer

Modified:
6 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add a utility method to the ia32 macro assembler to move a double immediate into an XMM register. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20160

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -0 lines)			Patch
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+17 lines, -0 lines	1 comment	Download
M	test/cctest/test-macro-assembler-ia32.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/197233011/diff/1/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): https://codereview.chromium.org/197233011/diff/1/src/ia32/macro-assembler-ia32.cc#newcode2850 src/ia32/macro-assembler-ia32.cc:2850: void MacroAssembler::Move(Register dst, Immediate imm) { As discussed ...

6 years, 9 months ago (2014-03-21 10:44:55 UTC) #2

titzer

6 years, 9 months ago (2014-03-21 12:16:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20160 (presubmit successful).

Expand Messages | Collapse Messages