Issue 197233010: Remove RULE_INPUT_PATH from inputs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197233010: Remove RULE_INPUT_PATH from inputs. (Closed)

Created:
6 years, 9 months ago by garykac

Modified:
6 years, 9 months ago

Reviewers:
Sergey Ulanov, Nico

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove RULE_INPUT_PATH from inputs. These inputs are not necessary because RULE_INPUT_PATH is always an input of a rule. And the .gyp spec doesn't guarantee that the RULE_INPUT_* variables exist for the inputs list. BUG= R=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257511

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -5 lines)			Patch
M	remoting/remoting_android.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/remoting_host.gypi	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	remoting/remoting_host_win.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

garykac

Committed patchset #1 manually as r257511 (presubmit successful).

6 years, 9 months ago (2014-03-17 23:02:30 UTC) #3

Message was sent while issue was closed.

lgmt

Thanks for the very fast fix!