Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: src/compiler/escape-analysis.cc

Issue 1972323004: [turbofan] Escape analysis treats guard nodes as escaping. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-pipeline-json-printing
Patch Set: All JS operators are escaping. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-602595.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/escape-analysis.h" 5 #include "src/compiler/escape-analysis.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/base/flags.h" 9 #include "src/base/flags.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 break; 705 break;
706 case IrOpcode::kObjectIsSmi: 706 case IrOpcode::kObjectIsSmi:
707 if (!IsAllocation(rep) && SetEscaped(rep)) { 707 if (!IsAllocation(rep) && SetEscaped(rep)) {
708 TRACE("Setting #%d (%s) to escaped because of use by #%d (%s)\n", 708 TRACE("Setting #%d (%s) to escaped because of use by #%d (%s)\n",
709 rep->id(), rep->op()->mnemonic(), use->id(), 709 rep->id(), rep->op()->mnemonic(), use->id(),
710 use->op()->mnemonic()); 710 use->op()->mnemonic());
711 return true; 711 return true;
712 } 712 }
713 break; 713 break;
714 case IrOpcode::kSelect: 714 case IrOpcode::kSelect:
715 case IrOpcode::kGuard:
715 if (SetEscaped(rep)) { 716 if (SetEscaped(rep)) {
716 TRACE("Setting #%d (%s) to escaped because of use by #%d (%s)\n", 717 TRACE("Setting #%d (%s) to escaped because of use by #%d (%s)\n",
717 rep->id(), rep->op()->mnemonic(), use->id(), 718 rep->id(), rep->op()->mnemonic(), use->id(),
718 use->op()->mnemonic()); 719 use->op()->mnemonic());
719 return true; 720 return true;
720 } 721 }
721 break; 722 break;
722 default: 723 default:
723 if (use->op()->EffectInputCount() == 0 && 724 if (use->op()->EffectInputCount() == 0 &&
724 uses->op()->EffectInputCount() > 0) { 725 uses->op()->EffectInputCount() > 0 &&
726 !IrOpcode::IsJsOpcode(use->opcode())) {
725 TRACE("Encountered unaccounted use by #%d (%s)\n", use->id(), 727 TRACE("Encountered unaccounted use by #%d (%s)\n", use->id(),
726 use->op()->mnemonic()); 728 use->op()->mnemonic());
727 UNREACHABLE(); 729 UNREACHABLE();
728 } 730 }
729 if (SetEscaped(rep)) { 731 if (SetEscaped(rep)) {
730 TRACE("Setting #%d (%s) to escaped because of use by #%d (%s)\n", 732 TRACE("Setting #%d (%s) to escaped because of use by #%d (%s)\n",
731 rep->id(), rep->op()->mnemonic(), use->id(), 733 rep->id(), rep->op()->mnemonic(), use->id(),
732 use->op()->mnemonic()); 734 use->op()->mnemonic());
733 return true; 735 return true;
734 } 736 }
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
1525 return true; 1527 return true;
1526 } 1528 }
1527 } 1529 }
1528 } 1530 }
1529 return false; 1531 return false;
1530 } 1532 }
1531 1533
1532 } // namespace compiler 1534 } // namespace compiler
1533 } // namespace internal 1535 } // namespace internal
1534 } // namespace v8 1536 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-602595.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698