content/renderer/pepper/pepper_file_io_host.cc - Issue 19723010: Pepper Message Filters: Port to use explicit permission grants in ChildProcessSecurityPolicy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_file_io_host.cc

Issue 19723010: Pepper Message Filters: Port to use explicit permission grants in ChildProcessSecurityPolicy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0044-write-support-remove-child-process-security-policy-bitmask-usage

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/child_process_security_policy.h ('K') | « content/public/browser/child_process_security_policy.h ('k') | content/renderer/pepper/pepper_plugin_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_file_io_host.cc

diff --git a/content/renderer/pepper/pepper_file_io_host.cc b/content/renderer/pepper/pepper_file_io_host.cc

index 934a336844098b157c3c074f68922959fadb136a..cdb2536df54bb013b39cc6028bb665f6ae6816c8 100644

--- a/content/renderer/pepper/pepper_file_io_host.cc

+++ b/content/renderer/pepper/pepper_file_io_host.cc

@@ -115,10 +115,7 @@ int32_t PepperFileIOHost::OnHostMsgOpen(

if (rv != PP_OK)

return rv;

- int flags = 0;

open_flags_ = open_flags;

- if (!::ppapi::PepperFileOpenFlagsToPlatformFileFlags(open_flags, &flags))

- return PP_ERROR_BADARGUMENT;

EnterResourceNoLock<PPB_FileRef_API> enter(file_ref_resource, true);

if (enter.failed())

@@ -140,7 +137,7 @@ int32_t PepperFileIOHost::OnHostMsgOpen(

if (file_ref->HasValidFileSystem()) {

file_system_url_ = file_ref->GetFileSystemURL();

plugin_delegate_->AsyncOpenFileSystemURL(

- file_system_url_, flags,

+ file_system_url_, open_flags,

base::Bind(

&PepperFileIOHost::ExecutePlatformOpenFileSystemURLCallback,

weak_factory_.GetWeakPtr(),

@@ -149,7 +146,7 @@ int32_t PepperFileIOHost::OnHostMsgOpen(

if (file_system_type_ != PP_FILESYSTEMTYPE_EXTERNAL)

return PP_ERROR_FAILED;

if (!plugin_delegate_->AsyncOpenFile(

- file_ref->GetSystemPath(), flags,

+ file_ref->GetSystemPath(), open_flags,

base::Bind(&PepperFileIOHost::ExecutePlatformOpenFileCallback,

weak_factory_.GetWeakPtr(),

context->MakeReplyMessageContext())))