ppapi/proxy/flash_file_resource.cc - Issue 19723010: Pepper Message Filters: Port to use explicit permission grants in ChildProcessSecurityPolicy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/flash_file_resource.cc

Issue 19723010: Pepper Message Filters: Port to use explicit permission grants in ChildProcessSecurityPolicy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0044-write-support-remove-child-process-security-policy-bitmask-usage

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/flash_file_resource.cc

diff --git a/ppapi/proxy/flash_file_resource.cc b/ppapi/proxy/flash_file_resource.cc

index a7db4c00a836ddbd25d586161508d0e38ef73c91..1387eb7c58b9bdcbdb2fa5ab3007a7cc45bc41c1 100644

--- a/ppapi/proxy/flash_file_resource.cc

+++ b/ppapi/proxy/flash_file_resource.cc

@@ -176,9 +176,8 @@ int32_t FlashFileResource::OpenFileHelper(const std::string& path,

PepperFilePath::Domain domain_type,

int32_t mode,

PP_FileHandle* file) {

- int flags = 0;

if (path.empty() ||

- !ppapi::PepperFileOpenFlagsToPlatformFileFlags(mode, &flags) ||

+ !ppapi::PepperFileOpenFlagsToPlatformFileFlags(mode, NULL) ||

!file)

return PP_ERROR_BADARGUMENT;

@@ -187,7 +186,7 @@ int32_t FlashFileResource::OpenFileHelper(const std::string& path,

IPC::Message unused;

ResourceMessageReplyParams reply_params;

int32_t error = GenericSyncCall(BROWSER,

- PpapiHostMsg_FlashFile_OpenFile(pepper_path, flags), &unused,

+ PpapiHostMsg_FlashFile_OpenFile(pepper_path, mode), &unused,

&reply_params);

if (error != PP_OK)

return error;

« no previous file with comments | « content/renderer/pepper/ppb_file_ref_impl.cc ('k') | ppapi/proxy/ppapi_messages.h » ('j') | no next file with comments »